fix: add parameter count validation to directionalLight() and pointLight() (fixes #8581)#8582
Open
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Open
fix: add parameter count validation to directionalLight() and pointLight() (fixes #8581)#8582MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Conversation
…ght() - Add argument count checks (2, 4, or 6 expected) with FES warnings for both directionalLight() and pointLight() - Invalid argument counts now show a friendly error listing accepted calling forms and return early to prevent runtime errors - Remove orphaned @todo comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds parameter count validation to directionalLight() and pointLight() in src/webgl/light.js, completing the
@TODO: check parameters numberthat was left in the code.Resolves #8581
Changes
@TODOcommentsNotes