fix: complete WebGL text.js TODO implementations and replace console.log with FES (fixes #8579)#8580
Open
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Open
Conversation
…log with FES - Complete _applyTextProperties(): removed orphaned TODO comments, added proper return value (this._pInst) matching the 2D renderer pattern - Add FES warning in textWidth() for non-OpenType fonts instead of silently returning 0 - Replace 2 console.log() in _renderText() with p5._friendlyError() for missing font and non-OpenType font warnings - Fix capitalization: 'Opentype' -> 'OpenType', 'Truetype' -> 'TrueType'
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes unfinished TODO implementations and replaces raw
console.log()calls withp5._friendlyError()in src/webgl/text.js.Resolves #8579
Changes
@TODOcomments, addedreturn this._pInstmatching the 2D renderer pattern// TODO: errorconsole.log→p5._friendlyError()for missing/incompatible font warningsOpentype→ OpenType,Truetype→TrueTypeNotes