Skip to content

Fix: stop media streams in p5.prototype.remove() by calling element.r… #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanchit2662 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix: stop media streams in p5.prototype.remove() by calling element.r… #8547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/core/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,13 @@ class p5 {

// remove DOM elements created by p5, and listeners
for (const e of this._elements) {
// Stop active media streams (webcam/microphone) to release hardware
if (p5.MediaElement && e instanceof p5.MediaElement) {
e.stop();
if (e.elt.srcObject !== null) {
e.elt.srcObject.getTracks().forEach(track => track.stop());
}
}
if (e.elt && e.elt.parentNode) {
e.elt.parentNode.removeChild(e.elt);
}
Expand Down