Skip to content

Suppress stroke warnings during buildGeometry #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skyash-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Suppress stroke warnings during buildGeometry #8411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/webgl/3d_primitives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ p5.prototype.plane = function(
planeGeom.computeFaces().computeNormals();
if (detailX <= 1 && detailY <= 1) {
planeGeom._makeTriangleEdges()._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw stroke on plane objects with more' +
' than 1 detailX or 1 detailY'
Expand Down Expand Up @@ -1208,7 +1208,7 @@ p5.prototype.box = function(width, height, depth, detailX, detailY) {
boxGeom.computeNormals();
if (detailX <= 4 && detailY <= 4) {
boxGeom._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw stroke on box objects with more' +
' than 4 detailX or 4 detailY'
Expand Down Expand Up @@ -1713,7 +1713,7 @@ p5.prototype.cylinder = function(
// normals are computed in call to _truncatedCone
if (detailX <= 24 && detailY <= 16) {
cylinderGeom._makeTriangleEdges()._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw stroke on cylinder objects with more' +
' than 24 detailX or 16 detailY'
Expand Down Expand Up @@ -1948,7 +1948,7 @@ p5.prototype.cone = function(
_truncatedCone.call(coneGeom, 1, 0, 1, detailX, detailY, cap, false);
if (detailX <= 24 && detailY <= 16) {
coneGeom._makeTriangleEdges()._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw stroke on cone objects with more' +
' than 24 detailX or 16 detailY'
Expand Down Expand Up @@ -2166,7 +2166,7 @@ p5.prototype.ellipsoid = function(
ellipsoidGeom.computeFaces();
if (detailX <= 24 && detailY <= 24) {
ellipsoidGeom._makeTriangleEdges()._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw stroke on ellipsoids with more' +
' than 24 detailX or 24 detailY'
Expand Down Expand Up @@ -2388,7 +2388,7 @@ p5.prototype.torus = function(radius, tubeRadius, detailX, detailY) {
torusGeom.computeFaces();
if (detailX <= 24 && detailY <= 16) {
torusGeom._makeTriangleEdges()._edgesToVertices();
} else if (this._renderer._doStroke) {
} else if (this._renderer._doStroke && !this._renderer.geometryBuilder) {
console.log(
'Cannot draw strokes on torus object with more' +
' than 24 detailX or 16 detailY'
Expand Down