Merged
Conversation
This reverts commit 67bd05b.
davepagurek
reviewed
Mar 24, 2026
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for taking on such a big across-the-board change, it'll be great to have all of this be more consistent! It's looking really good, I just left some comments about a few small things I noticed.
davepagurek
approved these changes
Mar 26, 2026
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Awesome, thanks for all your work on this! I think we're good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the various getters, plus tests, as detailed in ticket #8278
npm run lintpassesIncludes the following changes:
paramaterData.jsonfor getter functions to accept no-argument callstextAlign,scale,translate, etc.), the setter now accepts that objectbackground(either a color or image) torenderer.statep5.Colortest/unit/core/properties.jsrandomSeed()ornoiseSeed()