Skip to content

fix firefox scrollbar from fractional split pane size#4120

Merged
ksen0 merged 3 commits into
processing:developfrom
Nixxx19:nityam/fix-firefox-scrollbar-4046
May 21, 2026
Merged

fix firefox scrollbar from fractional split pane size#4120
ksen0 merged 3 commits into
processing:developfrom
Nixxx19:nityam/fix-firefox-scrollbar-4046

Conversation

@Nixxx19
Copy link
Copy Markdown
Member

@Nixxx19 Nixxx19 commented May 19, 2026

fixes #4046

the iframe was inheriting fractional pixel dimensions from its flex parent (eg 787.5px), so the sketch inside (which sees an integer 788) overflowed by 0.5px and triggered a scrollbar in firefox/brave.

floored the iframe width and height via a ResizeObserver on its parent and added display: block. tested locally in brave, scrollbar is gone, chrome unchanged.

@Nixxx19 Nixxx19 marked this pull request as ready for review May 19, 2026 08:03
Copy link
Copy Markdown
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nixxx19 I tested your PR locally and the scrollbars still exist. I checked on Brave and the issue is still present. On Chrome, there were no scrollbars before and there are still none.
Also, if you make any further changes, please share a preview as well.

Brave Preview:
image

@Nixxx19
Copy link
Copy Markdown
Member Author

Nixxx19 commented May 20, 2026

hey @yugalkaushik thanks for testing and sorry for not attaching a screenshot earlier. just pushed a fix, tested locally in brave and the scrollbar is gone, screenshot attached. mind giving it another try?

Screenshot 2026-05-20 at 4 15 24 PM

@yugalkaushik
Copy link
Copy Markdown
Contributor

@Nixxx19 I tested it locally and everything looks clean now. When you get some time, could you please test it on Firefox as well so we can confirm the issue is fixed once and for all? I’ll approve the PR after you verify it there.

@yugalkaushik
Copy link
Copy Markdown
Contributor

I tested it on firefox and it works. @Nixxx19 Thank you for the amazing work.
@ksen0 This PR can be merged.
image

@ksen0
Copy link
Copy Markdown
Member

ksen0 commented May 21, 2026

Thanks both!

@ksen0 ksen0 merged commit 5e5b3ce into processing:develop May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full-frame sketches have scroll bars by default

3 participants