Fix Back to Editor hover state gap and icon visibility #3733#4116
Open
SatyamKumarCS wants to merge 1 commit into
Open
Fix Back to Editor hover state gap and icon visibility #3733#4116SatyamKumarCS wants to merge 1 commit into
SatyamKumarCS wants to merge 1 commit into
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Pull request overview
This PR updates the desktop navigation header styling to address the “Back to Editor” hover treatment and back-arrow icon contrast.
Changes:
- Moves spacing from the no-icon nav item to the back link.
- Adds a targeted hover background for the back link.
- Updates the back icon fill color on hover.
|
|
||
| align-items: center; | ||
| height: 100%; | ||
| padding: 0 #{math.div(10, $base-font-size)}rem; |
|
|
||
|
|
||
| .nav__item.nav__item--no-icon:hover { | ||
| background-color: transparent !important; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3733
The navigation header had a visual bug where the hover state of the “Back to Editor” button would expand into the gap between it and the p5* logo, making the two elements appear merged. Additionally, the left-arrow icon lacked proper contrast on hover, making it difficult to see against the hover background. This PR corrects the hover bounding box and ensures icon visibility.
Demo:
Changes:
padding-leftfrom the list item container (.nav__item--no-icon) and moved it inside the link element (.nav__back-link). This ensures the hover background highlight is scoped strictly to the button area.button-hover-color, preventing it from "disappearing" against the hover background.height: 100%) and used flex centering to ensure the clickable area is vertically consistent with other nav items.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)fix-back-to-editor-hover) and is up to date with thedevelopbranch.