Skip to content

feat: Migrate Session.controller.js to typescript #3958

Open
Piyushrathoree wants to merge 3 commits intoprocessing:developfrom
Piyushrathoree:ts/migrate-session-controller
Open

feat: Migrate Session.controller.js to typescript #3958
Piyushrathoree wants to merge 3 commits intoprocessing:developfrom
Piyushrathoree:ts/migrate-session-controller

Conversation

@Piyushrathoree
Copy link

Fixes #3957

Changes:

  • Migrated server/controllers/session.controller.js to exactly matching TS file.
  • Created CreateSessionRequestBody, CreateSessionResponseBody, GetSessionResponseBody, and DestroySessionResponseBody types in server/types/session.ts.
  • Installed @types/express-session as a devDependency to allow the global Express Request object to understand req.session.destroy().

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript Migration: session.controller.js

1 participant