fix(auth): prevent crash when Google OAuth email is missing #3952
Open
KanhaiyaPandey wants to merge 1 commit intoprocessing:developfrom
Open
fix(auth): prevent crash when Google OAuth email is missing #3952KanhaiyaPandey wants to merge 1 commit intoprocessing:developfrom
KanhaiyaPandey wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in the Google OAuth strategy where the code directly accessed
profile._json.emails[0].valuewithout validating thatemailsexists andcontains at least one entry.
If Google does not return an email array, this results in:
TypeError: Cannot read property '0' of undefined
This PR adds proper validation and ensures the OAuth flow fails gracefully
instead of crashing.
Changes
profile.emails(or_json.emails) before accessing index 0primaryEmailvariabledone(null, false, { msg: 'Google account does not provide an email address.' })profile._json.emails[0].valueWhy This Is Needed
Google does not guarantee that the
emailsarray will be present(depending on scopes, account type, or privacy settings).
Without validation, the OAuth flow crashes instead of failing gracefully.
Testing
emailsCloses #3907