Fix: Control the behavior only by checking the options parameter.#3946
Open
SinhaS12 wants to merge 2 commits intoprocessing:developfrom
Open
Fix: Control the behavior only by checking the options parameter.#3946SinhaS12 wants to merge 2 commits intoprocessing:developfrom
SinhaS12 wants to merge 2 commits intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3911
findByEmailOrUsername()usedarguments.length === 2to decide whether to run the case-insensitive query. This is fragile and can behave inconsistently when the function is called with extra arguments (e.g. wrappers) or different call styles.Demo:
N/A (server-side logic change; no UI change).
Changes:
arguments.length === 2condition from the case-insensitive branch.options?.caseInsensitive.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123