fix(accessibility): correct label–input association in NewPasswordForm (#3908)#3942
Open
Irfan762 wants to merge 1 commit intoprocessing:developfrom
Open
fix(accessibility): correct label–input association in NewPasswordForm (#3908)#3942Irfan762 wants to merge 1 commit intoprocessing:developfrom
Irfan762 wants to merge 1 commit intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Author
|
Hi @raclim, I’ve submitted the PR for this issue. Could you please review when you have time? Thanks! |
Author
|
Hi @ksen0 , I’ve submitted the PR for this issue. Could you please review when you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken label–input association in
NewPasswordFormthat caused accessibility issues.The
htmlForattributes did not correctly match their corresponding inputidvalues, and one input ID contained spaces, which is invalid in HTML. This prevented screen readers from properly announcing the form fields (WCAG 2.1 Level A violation).Changes Made
htmlForandidfor the password fieldconfirmPassword)<label>correctly maps to its<input>Accessibility Impact
This restores proper label–input association and improves screen reader compatibility.
Issue
Closes #3908