Generated unique username not applied during account creation#3940
Open
Iron-56 wants to merge 1 commit intoprocessing:developfrom
Open
Generated unique username not applied during account creation#3940Iron-56 wants to merge 1 commit intoprocessing:developfrom
Iron-56 wants to merge 1 commit intoprocessing:developfrom
Conversation
Contributor
Author
|
@raclim I have verified and a different username is generated and the my sketch section shows different content. Earlier the server thinks as if it were same accounts. |
Contributor
Author
|
@raclim could you review when you're free? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixed an issue where username conflict occurs from a manual signup and then a github account signup using same username. Destructuring profile to get username does not create a reference to the profile object property so we must manually assign the value.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123