ci: add coverage reporting, bump deprecated action versions#3938
Open
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Open
ci: add coverage reporting, bump deprecated action versions#3938avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Conversation
Contributor
Author
|
@raclim Hey kept this intentionally small, bumped deprecated Actions to v4 and turned on Jest coverage output in CI so we finally get a baseline in logs. I set the global line threshold to 5% on purpose as a guardrail (not a quality target) so this won’t break existing work while still catching accidental drops. If you’re good with this, I can follow up with a separate PR to ratchet thresholds up gradually (e.g. +5% per pass) once we’ve got stable numbers for a week or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3895
Both
actions/checkoutandactions/setup-nodewere still on v2/v1 (Node 12, deprecated for ages, GitHub's been warning about it in every run). Also added--coverageto the test step with atext-summaryreporter and a 5% line threshold so we at least have a number to look at in CI.Changes: Bumped deprecated GitHub Actions to v4 and enabled Jest coverage in CI with a text summary plus a minimal 5% global line threshold so coverage regressions don’t slip by silently.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3895