fix(i18n): apply missing translations to MobileNav component#3935
Open
pranjal270 wants to merge 1 commit intoprocessing:developfrom
Open
fix(i18n): apply missing translations to MobileNav component#3935pranjal270 wants to merge 1 commit intoprocessing:developfrom
pranjal270 wants to merge 1 commit intoprocessing:developfrom
Conversation
Contributor
|
@pranjal270 Thank you for the PR. Please review the contribution guidelines, as we prefer translation changes only in languages you are proficient in or native to. Additionally, very large translation updates are generally not preferred since they are difficult to review properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3928
Some MobileNav UI labels ("My Stuff", "Settings", "Log Out", "by…") were hardcoded and did not respond to language changes. Additionally, the corresponding translation keys — including "Select Language" — were missing from non-English locale files.
Demo
Changes
MobileNav.jsxwitht()calls.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.