fix: accountform labels for current and new password#3930
Open
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Open
fix: accountform labels for current and new password#3930Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix accountform labels for current and new password
Issue:
Fixes #3912
The current
AccountFormcomponent useslabelelements whosehtmlForvalues do not match the correspondinginputidattributes for the "Current password" and "New password" fields. ThehtmlForvalues also contain spaces, which are not valid in HTMLid/forattributes. This breaks proper label–input association for screen readers and fails accessibility expectations.Changes:
AccountForm.tsxso that:label htmlFor="currentPassword"matchesinput id="currentPassword".label htmlFor="newPassword"matchesinput id="newPassword".htmlForvalues with spaces ("current password", "new password") to ensure valid HTML and correct screen reader behavior.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch (nityam/fix-accountform-labels).Fixes #3912).