Skip to content

fix: accountform labels for current and new password#3930

Open
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Nixxx19:nityam/fix-accountform-labels
Open

fix: accountform labels for current and new password#3930
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Nixxx19:nityam/fix-accountform-labels

Conversation

@Nixxx19
Copy link
Contributor

@Nixxx19 Nixxx19 commented Feb 24, 2026

fix accountform labels for current and new password

Issue:

Fixes #3912

The current AccountForm component uses label elements whose htmlFor values do not match the corresponding input id attributes for the "Current password" and "New password" fields. The htmlFor values also contain spaces, which are not valid in HTML id/for attributes. This breaks proper label–input association for screen readers and fails accessibility expectations.

Changes:

  • Updated AccountForm.tsx so that:
    • label htmlFor="currentPassword" matches input id="currentPassword".
    • label htmlFor="newPassword" matches input id="newPassword".
  • Removed invalid htmlFor values with spaces ("current password", "new password") to ensure valid HTML and correct screen reader behavior.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch (nityam/fix-accountform-labels).
  • is descriptively named and links to an issue number (Fixes #3912).
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccountForm: label htmlFor does not match input id (accessibility)

1 participant