Skip to content

fix:inconsitent in the for and id use#3929

Open
SinhaS12 wants to merge 3 commits intoprocessing:developfrom
SinhaS12:fix/inconsistent-in-id
Open

fix:inconsitent in the for and id use#3929
SinhaS12 wants to merge 3 commits intoprocessing:developfrom
SinhaS12:fix/inconsistent-in-id

Conversation

@SinhaS12
Copy link

@SinhaS12 SinhaS12 commented Feb 24, 2026

Issue:

Fixes #3912
This PR fixes an accessibility issue in AccountForm where the “Current Password” and “New Password” labels used invalid htmlFor values (with spaces) that did not match the corresponding input ids, breaking label–input association for assistive technologies.

Demo:

N/A (markup-only accessibility fix; no visual UI change expected).

Changes:

  • Update “Current Password” label htmlFor to currentPassword to match id="currentPassword".
  • Update “New Password” label htmlFor to newPassword to match id="newPassword".

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@SinhaS12
Copy link
Author

Hi , @raclim

I’ve made the requested changes. Could you please review the PR when you get a chance?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccountForm: label htmlFor does not match input id (accessibility)

1 participant