fix:inconsitent in the for and id use#3929
Open
SinhaS12 wants to merge 3 commits intoprocessing:developfrom
Open
fix:inconsitent in the for and id use#3929SinhaS12 wants to merge 3 commits intoprocessing:developfrom
SinhaS12 wants to merge 3 commits intoprocessing:developfrom
Conversation
Author
|
Hi , @raclim I’ve made the requested changes. Could you please review the PR when you get a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3912
This PR fixes an accessibility issue in
AccountFormwhere the “Current Password” and “New Password” labels used invalidhtmlForvalues (with spaces) that did not match the corresponding inputids, breaking label–input association for assistive technologies.Demo:
N/A (markup-only accessibility fix; no visual UI change expected).
Changes:
htmlFortocurrentPasswordto matchid="currentPassword".htmlFortonewPasswordto matchid="newPassword".I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123