-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fixes: Hindi translation does not apply on the homepage (works for Bangla and others) #3747 and Some text on the p5.js Editor “About” page is not translated #3485 #3772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request restructures the Hindi translation file to fix issues where Hindi translations were not applying correctly on the homepage and About page. The changes reorganize the JSON structure to match the reference en-US locale format, moving from an inconsistent nested structure to the standard format used by other working locales.
Key changes:
- Restructured the Hindi locale file (
translations/locales/hi/translations.json) to match the en-US reference format - Reordered keys in the
Preferencessection (moved CustomVersion keys before Addon keys) to match the reference structure - Updated the
Common.ErrorandCommon.ErrorARIAtranslations from transliteration ("एरर") to proper Hindi word ("ग़लती")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #3747
Fixes #3485
Issues
Hindi (
hi) translation did not apply on the homepage while other languages(e.g. Bangla
bn) worked correctly. (Bug: Hindi translation does not apply on the homepage (works for Bangla and others) #3747)Some text on the p5.js Editor “About” page was not translated when Hindi was
selected. (Some text on the p5.js Editor “About” page is not translated #3485)
Both issues stemmed from inconsistencies in the Hindi locale setup.
Root Cause
@translations/locales/hidid not follow the same structure as other working localeshiused a different format compared tobnaffecting both the homepage and the “About” page
Approach
hito follow the same format as thebnlocale file@translations/locales/hito match the structure used by other localesAbout page
Changes
hiformat to align with thebnlocale file@translations/locales/hiVerification
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranchFixes #3747,Fixes #3485)accessibility guidelines
Screenshots / Demo
About Page (Hindi translation applied)

Editor Page (Hindi translation applied)
