Skip to content

Conversation

@Urvi2727
Copy link

@Urvi2727 Urvi2727 commented Jan 1, 2026

Fixes #3747
Fixes #3485

Issues

  1. Hindi (hi) translation did not apply on the homepage while other languages
    (e.g. Bangla bn) worked correctly. (Bug: Hindi translation does not apply on the homepage (works for Bangla and others) #3747)

  2. Some text on the p5.js Editor “About” page was not translated when Hindi was
    selected. (Some text on the p5.js Editor “About” page is not translated #3485)

Both issues stemmed from inconsistencies in the Hindi locale setup.


Root Cause

  • @translations/locales/hi did not follow the same structure as other working locales
  • hi used a different format compared to bn
  • Duplicate / misplaced Hindi translation files existed
  • Because of this mismatch, certain keys were skipped during locale loading,
    affecting both the homepage and the “About” page

Approach

  • Updated hi to follow the same format as the bn locale file
  • Reorganized @translations/locales/hi to match the structure used by other locales
  • Removed duplicate and inconsistent Hindi translation files
  • Ensured all Hindi translations are loaded from a single, consistent root
  • Verified that translations now apply correctly on both the homepage and the
    About page

Changes

  • Changed hi format to align with the bn locale file
  • Fixed directory structure under @translations/locales/hi
  • Removed duplicate Hindi translation entries
  • Restored missing translations on the “About” page

Verification

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch
  • is descriptively named and links to issue numbers (Fixes #3747, Fixes #3485)
  • meets the standards outlined in the
    accessibility guidelines

Screenshots / Demo

About Page (Hindi translation applied)
About page – Hindi translation applied

Editor Page (Hindi translation applied)
Homepage – Hindi translation applied

Copilot AI review requested due to automatic review settings January 1, 2026 13:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request restructures the Hindi translation file to fix issues where Hindi translations were not applying correctly on the homepage and About page. The changes reorganize the JSON structure to match the reference en-US locale format, moving from an inconsistent nested structure to the standard format used by other working locales.

Key changes:

  • Restructured the Hindi locale file (translations/locales/hi/translations.json) to match the en-US reference format
  • Reordered keys in the Preferences section (moved CustomVersion keys before Addon keys) to match the reference structure
  • Updated the Common.Error and Common.ErrorARIA translations from transliteration ("एरर") to proper Hindi word ("ग़लती")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Urvi2727 and others added 3 commits January 1, 2026 19:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Hindi translation does not apply on the homepage (works for Bangla and others) Some text on the p5.js Editor “About” page is not translated

1 participant