-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
i18n: modernize and clean up translations for multiple locales #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Cleaned up Hindi (hi) translation file (removed duplicates, fixed indentation) - Updated Preferences and Nav sections for hi, es-419, zh-CN, it, ja, de, and fr-CA - Aligned Help menu keys across locales with en-US structure
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request modernizes and standardizes i18n translations across multiple locales by adding new Help menu items, updating Preferences sections with library management keys, and performing a comprehensive cleanup of the Hindi translation file.
- Adds three new Help menu items (ReportBug, ChatOnDiscord, PostOnTheForum) across all seven locales
- Updates Preferences sections with new library management and ARIA label keys for some locales
- Refactors the Hindi translation file to remove duplicates and fix indentation, significantly reducing its complexity
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| translations/locales/zh-CN/translations.json | Adds Help menu items and comprehensive Preferences updates including TitleHelmet, library management keys, ARIA labels, and clipboard utilities |
| translations/locales/ja/translations.json | Adds Help menu items and partial Preferences updates with library management and ARIA labels (missing some keys present in other locales) |
| translations/locales/it/translations.json | Adds Help menu items and partial Preferences updates with TitleHelmet, ARIA labels, and clipboard utilities (missing CustomVersion keys) |
| translations/locales/hi/translations.json | Major cleanup removing duplicates and fixing indentation, adds Help menu items and comprehensive Preferences updates |
| translations/locales/fr-CA/translations.json | Adds only Help menu items (no Preferences updates) |
| translations/locales/es-419/translations.json | Adds Help menu items and comprehensive Preferences updates including all new library management and utility keys |
| translations/locales/en-US/translations.json | Adds TitleHelmet key to Preferences section as the base reference |
| translations/locales/de/translations.json | Adds only Help menu items (no Preferences updates) |
| client/modules/IDE/components/Preferences/index.jsx | Updates ARIA label references from AddonOn/AddonOff to AddonOnARIA/AddonOffARIA and makes TitleHelmet translatable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "AddonOnARIA": "attivo", | ||
| "AddonOffARIA": "disattivo", | ||
| "SoundReference": "Visualizza il riferimento per p5.sound compatibile con p5.js {{version}}", | ||
| "CopyToClipboardSuccess": "Copiato negli appunti!", | ||
| "CopyToClipboardFailure": "Non è stato possibile copiare il testo, prova a selezionarlo e copiarlo manualmente." |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Italian translation is missing several Preferences keys that are present in other locales (e.g., zh-CN, es-419) in this PR. Missing keys include: CustomVersionTitle, CustomVersionInfo, and CustomVersionReset. Consider adding these for consistency with the other locales being updated in this PR.
| "ReportBug": "Signaler un bogue", | ||
| "ChatOnDiscord": "Discuter sur Discord", | ||
| "PostOnTheForum": "Publier sur le forum" |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The French-Canadian translation only updates the Nav.Help section but doesn't include any Preferences updates that are being added to other locales (hi, es-419, zh-CN, it, ja) in this PR. Missing keys include: TitleHelmet, AddonOnARIA, AddonOffARIA, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency.
| "ReportBug": "Fehler melden", | ||
| "ChatOnDiscord": "Auf Discord chatten", | ||
| "PostOnTheForum": "Im Forum posten" |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The German translation only updates the Nav.Help section but doesn't include any Preferences updates that are being added to other locales (hi, es-419, zh-CN, it, ja) in this PR. Missing keys include: TitleHelmet, LibraryManagement, LibraryVersion, LibraryVersionInfo, SoundAddon, PreloadAddon, ShapesAddon, DataAddon, AddonOnARIA, AddonOffARIA, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency.
| "Copy": "<bold>Donate Today!</bold> Support p5.js and the Processing Foundation." | ||
| }, | ||
| "CodemirrorFindAndReplace": { | ||
| "ToggleReplace": "टॉगल बदली करें", |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CodemirrorFindAndReplace section is missing the "Find" key that exists in the en-US version (line 57 in en-US). This key should be added between "ToggleReplace" and "FindPlaceholder" for consistency with the base locale.
| "ToggleReplace": "टॉगल बदली करें", | |
| "ToggleReplace": "टॉगल बदली करें", | |
| "Find": "खोजें", |
| "LibraryVersion": "p5.js バージョン", | ||
| "SoundAddon": "p5.sound.js アドオン・ライブラリ", | ||
| "PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload", | ||
| "ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes", | ||
| "DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events", | ||
| "AddonOnARIA": "オン", | ||
| "AddonOffARIA": "オフ", |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Japanese translation is missing several Preferences keys that are present in other locales (e.g., zh-CN, es-419) in this PR. Missing keys include: LibraryVersionInfo, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency with the other locales being updated in this PR.
| "LibraryVersion": "p5.js バージョン", | |
| "SoundAddon": "p5.sound.js アドオン・ライブラリ", | |
| "PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload", | |
| "ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes", | |
| "DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events", | |
| "AddonOnARIA": "オン", | |
| "AddonOffARIA": "オフ", | |
| "LibraryVersion": "p5.js バージョン", | |
| "LibraryVersionInfo": "使用する p5.js のバージョンを選択します。", | |
| "CustomVersionTitle": "カスタムバージョン", | |
| "CustomVersionInfo": "特定の p5.js バージョンの URL を指定して使用します。", | |
| "CustomVersionReset": "デフォルトのバージョンにリセット", | |
| "SoundAddon": "p5.sound.js アドオン・ライブラリ", | |
| "SoundReference": "p5.sound のリファレンスを開く", | |
| "PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload", | |
| "ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes", | |
| "DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events", | |
| "AddonOnARIA": "オン", | |
| "AddonOffARIA": "オフ", | |
| "CopyToClipboardSuccess": "クリップボードにコピーしました。", | |
| "CopyToClipboardFailure": "クリップボードへのコピーに失敗しました。", |
|
Hi @vivekyadav-3 Thank you for the contributions but for translation related contributions we request you only contribute to your native languages. Check out the guidelines here: https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/translations.md , Along with it please run the test cases. |
|
"Hi @yugalkaushik, thank you for the feedback!
i have removed the non-native translations and kept only the Hindi ones.I
have also verified the project structure locally.
Ready for another review.Thanks for the guidance."
…On Sun, Dec 28, 2025 at 6:07 PM Yugal Kaushik ***@***.***> wrote:
*yugalkaushik* left a comment (processing/p5.js-web-editor#3769)
<#3769 (comment)>
Hi @vivekyadav-3 <https://github.com/vivekyadav-3> Thank you for the
contributions but for translation related contributions we request you only
contribute to your native languages. Check out the guidelines here:
https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/translations.md
, Along with it please run the test cases.
—
Reply to this email directly, view it on GitHub
<#3769 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSGQEXFB6OVFG4UJN2AFZQL4D7FKNAVCNFSM6AAAAACQCEOKDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJUG4YTKNZZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
* <http://www.kiit.ac.in>*
*
Go Green: Kindly don't print this unless so
required.*
*
*
*Established U/S 3 of UGC Act and Accredited by NBA of
AICTE and NAAC of UGC*
Visit us @ *http://www.kiit.ac.in
<http://www.kiit.ac.in/>*
Follow us @* **|***Twitter
<https://www.twitter.com/KIITUniversity/>***|***Facebook**
<https://www.facebook.com/KIITUniversity>*|***Instagram
<https://www.instagram.com/KIITUniversity/>***|*
The information
contained in this electronic message and any
attachments to this message
are intended for the exclusive use of the
addressee(s) and may contain
proprietary, confidential or privileged
information. If you are not the
intended recipient, you should not
disseminate, distribute or copy this
e-mail. Please notify the sender
immediately and delete all copies of
this message and any attachments.
VIRUS WARNING: Computer viruses can
be
transmitted via email. The recipient should check this email and any
attachments for the presence of viruses. The institute accepts no liability
for any damage caused by any virus transmitted by this email.
|
Fixes #3769
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123