Skip to content

Conversation

@vivekyadav-3
Copy link

@vivekyadav-3 vivekyadav-3 commented Dec 26, 2025

  • Cleaned up Hindi (hi) translation file (removed duplicates, fixed indentation)
  • Updated Preferences and Nav sections for hi, es-419, zh-CN, it, ja, de, and fr-CA
  • Aligned Help menu keys across locales with en-US structure

Fixes #3769
Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

- Cleaned up Hindi (hi) translation file (removed duplicates, fixed indentation)
- Updated Preferences and Nav sections for hi, es-419, zh-CN, it, ja, de, and fr-CA
- Aligned Help menu keys across locales with en-US structure
Copilot AI review requested due to automatic review settings December 26, 2025 15:55
@welcome
Copy link

welcome bot commented Dec 26, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes and standardizes i18n translations across multiple locales by adding new Help menu items, updating Preferences sections with library management keys, and performing a comprehensive cleanup of the Hindi translation file.

  • Adds three new Help menu items (ReportBug, ChatOnDiscord, PostOnTheForum) across all seven locales
  • Updates Preferences sections with new library management and ARIA label keys for some locales
  • Refactors the Hindi translation file to remove duplicates and fix indentation, significantly reducing its complexity

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
translations/locales/zh-CN/translations.json Adds Help menu items and comprehensive Preferences updates including TitleHelmet, library management keys, ARIA labels, and clipboard utilities
translations/locales/ja/translations.json Adds Help menu items and partial Preferences updates with library management and ARIA labels (missing some keys present in other locales)
translations/locales/it/translations.json Adds Help menu items and partial Preferences updates with TitleHelmet, ARIA labels, and clipboard utilities (missing CustomVersion keys)
translations/locales/hi/translations.json Major cleanup removing duplicates and fixing indentation, adds Help menu items and comprehensive Preferences updates
translations/locales/fr-CA/translations.json Adds only Help menu items (no Preferences updates)
translations/locales/es-419/translations.json Adds Help menu items and comprehensive Preferences updates including all new library management and utility keys
translations/locales/en-US/translations.json Adds TitleHelmet key to Preferences section as the base reference
translations/locales/de/translations.json Adds only Help menu items (no Preferences updates)
client/modules/IDE/components/Preferences/index.jsx Updates ARIA label references from AddonOn/AddonOff to AddonOnARIA/AddonOffARIA and makes TitleHelmet translatable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 193 to 197
"AddonOnARIA": "attivo",
"AddonOffARIA": "disattivo",
"SoundReference": "Visualizza il riferimento per p5.sound compatibile con p5.js {{version}}",
"CopyToClipboardSuccess": "Copiato negli appunti!",
"CopyToClipboardFailure": "Non è stato possibile copiare il testo, prova a selezionarlo e copiarlo manualmente."
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Italian translation is missing several Preferences keys that are present in other locales (e.g., zh-CN, es-419) in this PR. Missing keys include: CustomVersionTitle, CustomVersionInfo, and CustomVersionReset. Consider adding these for consistency with the other locales being updated in this PR.

Copilot uses AI. Check for mistakes.
Comment on lines 31 to 33
"ReportBug": "Signaler un bogue",
"ChatOnDiscord": "Discuter sur Discord",
"PostOnTheForum": "Publier sur le forum"
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The French-Canadian translation only updates the Nav.Help section but doesn't include any Preferences updates that are being added to other locales (hi, es-419, zh-CN, it, ja) in this PR. Missing keys include: TitleHelmet, AddonOnARIA, AddonOffARIA, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency.

Copilot uses AI. Check for mistakes.
Comment on lines 30 to 32
"ReportBug": "Fehler melden",
"ChatOnDiscord": "Auf Discord chatten",
"PostOnTheForum": "Im Forum posten"
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The German translation only updates the Nav.Help section but doesn't include any Preferences updates that are being added to other locales (hi, es-419, zh-CN, it, ja) in this PR. Missing keys include: TitleHelmet, LibraryManagement, LibraryVersion, LibraryVersionInfo, SoundAddon, PreloadAddon, ShapesAddon, DataAddon, AddonOnARIA, AddonOffARIA, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency.

Copilot uses AI. Check for mistakes.
"Copy": "<bold>Donate Today!</bold> Support p5.js and the Processing Foundation."
},
"CodemirrorFindAndReplace": {
"ToggleReplace": "टॉगल बदली करें",
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodemirrorFindAndReplace section is missing the "Find" key that exists in the en-US version (line 57 in en-US). This key should be added between "ToggleReplace" and "FindPlaceholder" for consistency with the base locale.

Suggested change
"ToggleReplace": "टॉगल बदली करें",
"ToggleReplace": "टॉगल बदली करें",
"Find": "खोजें",

Copilot uses AI. Check for mistakes.
Comment on lines 184 to 190
"LibraryVersion": "p5.js バージョン",
"SoundAddon": "p5.sound.js アドオン・ライブラリ",
"PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload",
"ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes",
"DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events",
"AddonOnARIA": "オン",
"AddonOffARIA": "オフ",
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Japanese translation is missing several Preferences keys that are present in other locales (e.g., zh-CN, es-419) in this PR. Missing keys include: LibraryVersionInfo, CustomVersionTitle, CustomVersionInfo, CustomVersionReset, SoundReference, CopyToClipboardSuccess, and CopyToClipboardFailure. Consider adding these for consistency with the other locales being updated in this PR.

Suggested change
"LibraryVersion": "p5.js バージョン",
"SoundAddon": "p5.sound.js アドオン・ライブラリ",
"PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload",
"ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes",
"DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events",
"AddonOnARIA": "オン",
"AddonOffARIA": "オフ",
"LibraryVersion": "p5.js バージョン",
"LibraryVersionInfo": "使用する p5.js のバージョンを選択します。",
"CustomVersionTitle": "カスタムバージョン",
"CustomVersionInfo": "特定の p5.js バージョンの URL を指定して使用します。",
"CustomVersionReset": "デフォルトのバージョンにリセット",
"SoundAddon": "p5.sound.js アドオン・ライブラリ",
"SoundReference": "p5.sound のリファレンスを開く",
"PreloadAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Preload",
"ShapesAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Shapes",
"DataAddon": "p5.js 1.x 互換性アドオン・ライブラリ — Data & Events",
"AddonOnARIA": "オン",
"AddonOffARIA": "オフ",
"CopyToClipboardSuccess": "クリップボードにコピーしました。",
"CopyToClipboardFailure": "クリップボードへのコピーに失敗しました。",

Copilot uses AI. Check for mistakes.
@yugalkaushik
Copy link
Contributor

Hi @vivekyadav-3 Thank you for the contributions but for translation related contributions we request you only contribute to your native languages. Check out the guidelines here: https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/translations.md , Along with it please run the test cases.

@vivekyadav-3
Copy link
Author

vivekyadav-3 commented Dec 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants