-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated Hindi translation #3763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
hi @103Seeker , i noticed you have literally converted the meanings, can you explain the reason, i mean either way it's understandable |
Hello @NalinDalal, thank you for pointing this out — I really appreciate you taking the time to review it. I intended to make the translations feel easy and readable for the Hindi users, so I opted to use common Hindi expressions rather than direct English transliterations. But, I completely understand that consistency across the app is very important. I will be more than happy to revise the wording if a more literal approach is preferred. This is my first time contributing here, so I am keen to learn and improve. I would really appreciate your guidance on what approach would be best to follow. |
|
Hi @103Seeker , I don't understand, have you discussed this with any of maintainers?? |
No @NalinDalal, I worked on this independently after reading the translation.md guidelines. I didn’t discuss it with a maintainer beforehand. But I agree that maintainers should have the final say on the preferred approach. I am happy to revise the changes based on their direction. |
|
Hello, @raclim, I worked on this after reading the translation guidelines in translation.md and made the changes independently. For some of the strings, I chose more commonly used Hindi words instead of direct English transliterations, with the intention of making the text feel more natural and readable for native Hindi users. If you’d prefer the translations to stay closer to literal wording, or want the scope limited differently, I’m completely okay adjusting the changes. Please let me know what approach you’d recommend — I would really appreciate your guidance. Thanks for your time. |
yugalkaushik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @103Seeker Thank you for the PR. I kindly request that translation contributions be submitted in smaller chunks. Smaller, incremental contributions will help us review the changes more effectively and approve them faster.
yes you can work on this fix. |
Hello, @yugalkaushik Thank you for the feedback! Before making further wording changes: for Hindi translations here, should we prefer closer literal consistency with the English strings, or more natural Hindi phrasing when both are understandable? I will align any future updates with the preferred approach. |
We can go with natural hindi phrasing that make sense not just translating the english strings to hindi. |
Hello,
This is my first contribution to the p5.js web editor, and I have worked on improving the Hindi (
hi) translations.While reviewing the translation file, I noticed duplicate sections, few missing keys, and some inconsistencies.
What I changed
I’m still learning and would really appreciate any feedback or suggestions.
Thank you for your time and review