Skip to content

chore: graduate primer_react_overlay_max_height_clamp_to_viewport #7733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francinelucca wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: graduate primer_react_overlay_max_height_clamp_to_viewport #7733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
714ff7b
chore: graduate primer_react_overlay_max_height_clamp_to_viewport
francinelucca Apr 7, 2026
3b157e6
add changeset
francinelucca Apr 7, 2026
cf4f841
remove unused import
francinelucca Apr 7, 2026
b90c0ce
fix: add 100vh fallbacks for dvh in Overlay and ActionMenu CSS
Copilot Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/graduate-overlay-max-height-clamp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': minor
---

Overlay: Graduate `primer_react_overlay_max_height_clamp_to_viewport` feature flag

The max-height of overlays is now clamped to the viewport height by default using `min(size, 100dvh)`. This prevents overlays from extending beyond the viewport on smaller screens.
49 changes: 24 additions & 25 deletions packages/react/src/ActionMenu/ActionMenu.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,44 +25,43 @@

/* Max-height size tokens (mirror Overlay sizes) */
&:where([data-max-height-xsmall]) {
max-height: 192px;
}
max-height: min(192px, 100vh);

&:where([data-max-height-small]) {
max-height: 256px;
@supports (height: 100dvh) {
max-height: min(192px, 100dvh);
}
}

&:where([data-max-height-medium]) {
max-height: 320px;
}
&:where([data-max-height-small]) {
max-height: min(256px, 100vh);

&:where([data-max-height-large]) {
max-height: 432px;
@supports (height: 100dvh) {
max-height: min(256px, 100dvh);
}
}

&:where([data-max-height-xlarge]) {
max-height: 600px;
}
&:where([data-max-height-medium]) {
max-height: min(320px, 100vh);

/* Max-height size tokens clamped to viewport (enabled via feature flag) */
&:where([data-max-height-clamp-to-viewport][data-max-height-xsmall]) {
max-height: min(192px, 100dvh);
@supports (height: 100dvh) {
max-height: min(320px, 100dvh);
}
}

&:where([data-max-height-clamp-to-viewport][data-max-height-small]) {
max-height: min(256px, 100dvh);
}
&:where([data-max-height-large]) {
max-height: min(432px, 100vh);

&:where([data-max-height-clamp-to-viewport][data-max-height-medium]) {
max-height: min(320px, 100dvh);
@supports (height: 100dvh) {
max-height: min(432px, 100dvh);
}
}

&:where([data-max-height-clamp-to-viewport][data-max-height-large]) {
max-height: min(432px, 100dvh);
}
&:where([data-max-height-xlarge]) {
max-height: min(600px, 100vh);

&:where([data-max-height-clamp-to-viewport][data-max-height-xlarge]) {
max-height: min(600px, 100dvh);
@supports (height: 100dvh) {
max-height: min(600px, 100dvh);
}
}

&:where([data-max-height-fit-content]) {
Expand Down
4 changes: 0 additions & 4 deletions packages/react/src/ActionMenu/ActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import styles from './ActionMenu.module.css'
import {useResponsiveValue, type ResponsiveValue} from '../hooks/useResponsiveValue'
import {isSlot} from '../utils/is-slot'
import type {FCWithSlotMarker, WithSlotMarker} from '../utils/types/Slots'
import {useFeatureFlag} from '../FeatureFlags'
import {DialogContext} from '../Dialog/Dialog'

export type MenuCloseHandler = (
Expand Down Expand Up @@ -330,8 +329,6 @@ const Overlay: FCWithSlotMarker<React.PropsWithChildren<MenuOverlayProps>> = ({
}
}, [anchorRef])

const featureFlagMaxHeightClampToViewport = useFeatureFlag('primer_react_overlay_max_height_clamp_to_viewport')

const isInsideDialog = useContext(DialogContext) !== undefined

return (
Expand All @@ -354,7 +351,6 @@ const Overlay: FCWithSlotMarker<React.PropsWithChildren<MenuOverlayProps>> = ({
ref={containerRef}
className={styles.ActionMenuContainer}
data-variant={responsiveVariant}
{...(featureFlagMaxHeightClampToViewport ? {'data-max-height-clamp-to-viewport': ''} : {})}
{...(overlayProps.overflow ? {[`data-overflow-${overlayProps.overflow}`]: ''} : {})}
{...(overlayProps.maxHeight ? {[`data-max-height-${overlayProps.maxHeight}`]: ''} : {})}
>
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/FeatureFlags/DefaultFeatureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ export const DefaultFeatureFlags = FeatureFlagScope.create({
primer_react_select_panel_order_selected_at_top: false,
primer_react_select_panel_remove_active_descendant: false,
primer_react_spinner_synchronize_animations: false,
primer_react_overlay_max_height_clamp_to_viewport: false,
})
49 changes: 24 additions & 25 deletions packages/react/src/Overlay/Overlay.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,44 +102,43 @@
}

&:where([data-max-height-xsmall]) {
max-height: 192px;
}
max-height: min(192px, 100vh);

&:where([data-max-height-small]) {
max-height: 256px;
@supports (height: 100dvh) {
max-height: min(192px, 100dvh);
}
}

&:where([data-max-height-medium]) {
max-height: 320px;
}
&:where([data-max-height-small]) {
max-height: min(256px, 100vh);

&:where([data-max-height-large]) {
max-height: 432px;
@supports (height: 100dvh) {
max-height: min(256px, 100dvh);
}
}

&:where([data-max-height-xlarge]) {
max-height: 600px;
}
&:where([data-max-height-medium]) {
max-height: min(320px, 100vh);

/* Max-height size tokens clamped to viewport (enabled via feature flag) */
&:where([data-max-height-clamp-to-viewport][data-max-height-xsmall]) {
max-height: min(192px, 100dvh);
@supports (height: 100dvh) {
max-height: min(320px, 100dvh);
}
}

&:where([data-max-height-clamp-to-viewport][data-max-height-small]) {
max-height: min(256px, 100dvh);
}
&:where([data-max-height-large]) {
max-height: min(432px, 100vh);

&:where([data-max-height-clamp-to-viewport][data-max-height-medium]) {
max-height: min(320px, 100dvh);
@supports (height: 100dvh) {
max-height: min(432px, 100dvh);
}
}

&:where([data-max-height-clamp-to-viewport][data-max-height-large]) {
max-height: min(432px, 100dvh);
}
&:where([data-max-height-xlarge]) {
max-height: min(600px, 100vh);

&:where([data-max-height-clamp-to-viewport][data-max-height-xlarge]) {
max-height: min(600px, 100dvh);
@supports (height: 100dvh) {
max-height: min(600px, 100dvh);
}
}

&:where([data-max-height-fit-content]) {
Expand Down
2 changes: 0 additions & 2 deletions packages/react/src/Overlay/Overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ const Overlay = React.forwardRef<HTMLDivElement, internalOverlayProps>(
forwardedRef,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
): ReactElement<any> => {
const featureFlagMaxHeightClampToViewport = useFeatureFlag('primer_react_overlay_max_height_clamp_to_viewport')
const overlayRef = useRef<HTMLDivElement>(null)
const mergedRef = useMergedRefs(forwardedRef, overlayRef)
const slideAnimationDistance = 8 // var(--base-size-8), hardcoded to do some math
Expand Down Expand Up @@ -245,7 +244,6 @@ const Overlay = React.forwardRef<HTMLDivElement, internalOverlayProps>(
height={height}
visibility={visibility}
data-responsive={responsiveVariant}
{...(featureFlagMaxHeightClampToViewport ? {'data-max-height-clamp-to-viewport': ''} : {})}
{...props}
/>
)
Expand Down
Loading