Shrink gutter around dialog on very small screen heights #7471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8387e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
llastflowers
added
integration-tests: skipped manually
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Dialog sizing for extremely short viewports to preserve usable scrollable space (addressing github/accessibility-audits#14888).
Changes:
- Added a narrow + very-short-viewport media query to reduce Dialog
max-height/max-widthgutters. - Allows the Dialog body’s scrollable region to remain visible on very small screen heights.
github-actions
bot
requested a deployment
to
storybook-preview-7471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/github/accessibility-audits/issues/14888
Changelog
New
Added new breakpoint for very small screen heights to shrink gutter around Dialog modal so that the scrollable region doesn't disappear.
Before
After
Rollout strategy
Testing & Reviewing
Merge checklist