removing undefined from AstPath<PrintableNode | undefined>#1512
Open
removing undefined from AstPath<PrintableNode | undefined>#1512
undefined from AstPath<PrintableNode | undefined>#1512Conversation
Janther
force-pushed
the
get-visitor-keys
branch
from
3707456 to
dc09696
Compare
…it's not required
Janther
force-pushed
the
get-visitor-keys
branch
from
dc09696 to
4ba5e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since it's not required with our current print strategy.
as a bonus I added
getVisitorKeysto minimise the visits to nodes prettier will make during their process. (there is a small bump in the speed of our tests)Also @fvictorio what's your input on prettier/prettier#19041 (comment)? I'm inclined in keeping our printing approach as is and only address it if in a future version, prettier decides to do something different when passing
undefinedlike throwing.