perf: Making UV the default installer, unless specified explicitly#5733
perf: Making UV the default installer, unless specified explicitly#5733suleman1412 wants to merge 9 commits intoprefix-dev:mainfrom
Conversation
|
@Hofer-Julian this PR aims to make UV the default installer in pixi_build_python unless specified explicity in the toml file |
|
Hi @Hofer-Julian / @baszalmstra , this PR aims to make uv as the default installer until explicitly specified in the config toml file. Please have a look at it when possible |
|
|
||
| /// Determine the installer from an iterator of dependency package names. | ||
| /// Checks if "uv" is present in the package names. | ||
| pub fn determine_installer_from_names<'a>( |
There was a problem hiding this comment.
Why remove? Cant we check if an installer is set based on the dependencies and use that, otherwise use the default?
| /// compatibility with packages that require pip-specific behavior. | ||
| /// Supported values: `"uv"` (default), `"pip"` | ||
| #[serde(default)] | ||
| pub installer: Option<Installer>, |
There was a problem hiding this comment.
I dont see why we need this. Lets just keepnthe behavior where this is derived
|
@baszalmstra my previous implementation was based on checking what we used in the dependencies and picking based on that. You can find it here — #5669 Please let me know if my understanding of the issue is correct, or if there's a different direction you had in mind. |
2 participants
Description
This works on making the uv the default installer in pixi_build_python crate, unless specified in the config file to be pip
Fixes #5666
How Has This Been Tested?
cargo test -p pixi_build_pythonAI Disclosure
Tools: Claude
Checklist:
schema/model.py.