[firestartr-bootstrap] Add argo events ingress annotations for health checks#428
Merged
jalvarezit merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AWS ALB Ingress annotations to configure Argo Events ingress health checks in the firestartr-bootstrap rendered deployment values.
Changes:
- Configure ALB health check protocol/port/path and success codes for Argo Events ingress
- Set target group deregistration delay attribute
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| alb.ingress.kubernetes.io/ssl-redirect: "443" | ||
| alb.ingress.kubernetes.io/target-type: ip | ||
| alb.ingress.kubernetes.io/healthcheck-protocol: HTTP | ||
| alb.ingress.kubernetes.io/healthcheck-port: http |
There was a problem hiding this comment.
alb.ingress.kubernetes.io/healthcheck-port does not accept a named port like http; for AWS Load Balancer Controller it must be an integer port (e.g., 80) or traffic-port. With http the controller may reject the Ingress or the ALB health checks will fail, leaving targets unhealthy.
Suggested change
| alb.ingress.kubernetes.io/healthcheck-port: http | |
| alb.ingress.kubernetes.io/healthcheck-port: traffic-port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #427