refactor: consolidate Algolia search logic into algolia-search.js#823
Open
anuj452005 wants to merge 1 commit intoprecice:masterfrom
Open
refactor: consolidate Algolia search logic into algolia-search.js#823anuj452005 wants to merge 1 commit intoprecice:masterfrom
anuj452005 wants to merge 1 commit intoprecice:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the Algolia search implementation into a single file,
eliminating duplicate logic between _includes/algolia.html and
js/algolia-search.js.
Problem
The search logic existed in two places:
This violated the single source of truth principle, prevented browser
caching of the search JS, and added unnecessary complexity to the layout template.
Changes
<script src>tag⌘K/Ctrl+K)No functional changes intended
Search behavior, keyboard shortcuts, and UI remain identical.
This is a structural refactor only.
Testing
bundle exec jekyll serve -lcloses #796