fix: update Font Awesome icon classes to FA6 format#822
Open
praaatap wants to merge 1 commit intoprecice:masterfrom
Open
fix: update Font Awesome icon classes to FA6 format#822praaatap wants to merge 1 commit intoprecice:masterfrom
praaatap wants to merge 1 commit intoprecice:masterfrom
Conversation
Update icon class prefix from deprecated FA4 'fa' to FA6 'fas' in alert blocks and custom Liquid blocks. Also fixes a typo 'fa-fa-hands-wash' (double prefix) that prevented the Disclaimer icon from rendering, and updates the deprecated 'fa-warning' alias to 'fa-exclamation-triangle'.
MakisH
added
technical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update icon class prefix from deprecated FA4 'fa' to FA6 'fas' in alert blocks and custom Liquid blocks. Additionally, corrects a typo 'fa-fa-hands-wash' (double prefix) that was preventing the Disclaimer icon from displaying properly
Description
This Pull Request will update the Font Awesome icon prefixes throughout the site's alert data and custom Liquid blocks to reflect the new FA6 style. Additionally, this PR will correct a specific typo that was causing the Disclaimer icon to not display properly on the site.
Changes Made
faprefix to the new Font Awesome 6fas(solid) prefix in [_data/alerts.yml]and [_plugins/customblocks.rb]fa-fa-hands-washtypo in [_data/alerts.yml](line 5). The double prefix was preventing the icon from rendering properly on the live site.fa-warningtofa-exclamation-triangleto reflect the new Font Awesome naming conventions. ## Why this is importantUsing the new
fasprefixes in the latest Font Awesome 6 library will provide better performance and consistency across modern browsers. More importantly, this PR will fix the broken Disclaimer icon due to a high-impact typo.