Feat: Sequnce Diagram SVGs into Mermaid renders#794
Open
hanzalahwaheed wants to merge 2 commits intoprecice:masterfrom
Open
Feat: Sequnce Diagram SVGs into Mermaid renders#794hanzalahwaheed wants to merge 2 commits intoprecice:masterfrom
hanzalahwaheed wants to merge 2 commits intoprecice:masterfrom
Conversation
Member
|
Thank you @hanzalahwaheed, this is useful. We will eventually review it and see how it might work together with other documentation as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #792
I've tried to convert the diagrams into mermaid renders. Here are the tow outputs that I have. Need help choosing the better one.
serial coupling diagram
original screenshot
mermaid render A
This is a more direct one-to-one mapping of the diagram.
mermaid render B
This is a more semantic render.
@MakisH which one do you think is a better render? I'm inclined towards A but the loop box of B is also nice.