New adapter: Adpixis #5965
New adapter: Adpixis #5965
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/adpixis.md
Outdated
|
|
||
| | Name | Scope | Description | Example | Type | | ||
| |:--------------|:---------|:--------------------------------------------------------------|:-----------------------|:----------| | ||
| | `host` | required | Ad network's RTB host | `'<adserving domain>'` | `string` | |
There was a problem hiding this comment.
Sorry, host cannot be a required parameter. See https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#consider-your-geography
There was a problem hiding this comment.
The comment below suggests that 'host' is only needed for Prebid.js, but the metadata field says pbjs: false. Something's off.
There was a problem hiding this comment.
@bretg thanks for your comments, we will fix everything, about the host - we use it only as query parameter for PBS to identify the publisher on our side
https://github.com/prebid/prebid-server/blob/master/static/bidder-info/limelightDigital.yaml#L1
There was a problem hiding this comment.
Sorry, 'host' isn't fixed. PBS does not allow any kind of domain (e.g. adpixis-rtb.com) as a required parameter. It's ok to be an optional parameter, so the adapter has to have a reasonable default.
The way to think about this is from the publisher's perspective:
- It's lazy to assume that your publisher customers can geo-balance your endpoints
- It's unreasonably duplicative to make them pass something like this to the limelight endpoint just to identify the alias.
The way you need to do that is to just hardcode the alias domain in your YAML file. e.g.
"http://ads-pbs.ortb.net/openrtb/{{.PublisherID}}?host=adpixis-rtb.com"
There was a problem hiding this comment.
Fixed. I've set Host to optional
There was a problem hiding this comment.
Is this "host" parameter different for each customer? Different for each request?
I do like the idea of renaming this because "host" has a meaning that may not be relevant here. However, you already have a "PublisherId" parameter. How would "publisher" differ from "publisherId"?
@apykhteyev can you please address these questions?
There was a problem hiding this comment.
The limelight digital adapter, which adpixis is an alias of, still has host as required despite the documentation change here to optional.
Host does not correspond to the bidder domain, though I imagine it is being used to route requests internally somehow. Is that the case @apykhteyev? If that is true, @bretg does this really have to be optional?
There was a problem hiding this comment.
The important thing is that we do not force publishers decide how to route each request. I agree the 'host' parameter is misnamed if it's just something like an account ID.
There was a problem hiding this comment.
@bretg @bsardo we did host parameter optional as you requested for this adapter. Even I can remove it from here it all, but I can't make it optional for our limelight digital adapter.
Let me try to explain our business.
We offer our RTB solution as SaaS for multiple clients and they use our infrastructure. Most of our clients request whitelabel domain and whitelabel pbs adapter. So it's ok we can create this alias and we don't require this host parameter and it's enough to have just publisherId
But some of clients don't need whitelabel solution and use our default domain ortb.net. So internally we use their client dedicated subdomain to differentiate request from different clients. Different clients could have same publisher ids, that why just publisherId is not enough for main limelightDigital adapter. As PBS don't allow to use dynamic subdomain - we moved this host to query parameters, and use it internally to understand what's client send us request from regular limelightAdapter. Our main adapter don't use host for any rerouting and just pass it as is for backend processing
And as I said we remove host from whitelabeled version. Hope it clarifies. Let me know for any questions
remove required fields
Set Host to Optional
5 participants
🏷 Type of documentation
📋 Checklist