Skip to content

Conversation

@sebhtml
Copy link
Contributor

@sebhtml sebhtml commented Mar 19, 2025

Why ?

In the Prebid Server documentation, it says that schain is read from source.ext.schain.
But OpenRTB 2.6 says it is read from source.schain. See OpenRTB 2.6, Section 3.2.2 - Object: Source and OpenRTB 2.6, Section 3.2.25 - Object: SupplyChain.

Furthermore, schain is in source.schain according to a discussion from 2022 in prebid/prebid-server#2139 :

The committee has agreed to move extended locations to the new locations. e.g. source.ext.schain to source.schain.

Deploy Previews:

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples
  • Prebid Server documentation

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit dad47fe
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67dc611f675b4100085734ca
😎 Deploy Preview https://deploy-preview-5955--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lpagnypubstack lpagnypubstack requested a review from bretg March 19, 2025 20:28
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny coincidence! I just worked on this yesterday.

There are some examples that show case the old location. Would you mind adapting those as well? This mostly affects AMP & App examples involving stored requests.

I wasn't able to find any other instances on the spot.

@muuki88 muuki88 added the LGTM label Mar 20, 2025
@sebhtml
Copy link
Contributor Author

sebhtml commented Mar 20, 2025

Funny coincidence! I just worked on this yesterday.

There are some examples that show case the old location. Would you mind adapting those as well? This mostly affects AMP & App examples involving stored requests.

I wasn't able to find any other instances on the spot.

hi @muuki88

I modified the page that you pointed: 342b738

I also found another instance in the auction request documentation of Prebid Server: dad47fe

@muuki88 muuki88 merged commit e3990a5 into prebid:master Mar 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants