Skip to content

Conversation

@pratik-chavan-advertising-dot-com
Copy link
Contributor

@pratik-chavan-advertising-dot-com pratik-chavan-advertising-dot-com commented Mar 12, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

prebid/Prebid.js#12878
prebid/prebid-server#4258

@netlify
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit cdccdba
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/6835e5a7896d980008f54ba4
😎 Deploy Preview https://deploy-preview-5943--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bsardo bsardo assigned bsardo and unassigned bsardo Mar 20, 2025
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename on the Prebid.js side was premature, IMO. The ability for publishers to build your imds adapter into their package using the download page is now broken.

Here's what you need to do to fix:

  • Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
  • Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.

@patmmccann
Copy link
Collaborator

The rename on the Prebid.js side was premature, IMO. The ability for publishers to build your imds adapter into their package using the download page is now broken.

Here's what you need to do to fix:

  • Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
  • Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.

All we did was merge the change into the unreleased 10 branch; it isnt in master

@bretg
Copy link
Contributor

bretg commented Mar 31, 2025

All we did was merge the change into the unreleased 10 branch; it isnt in master

Cool.

I still recommend doing these things:

  • Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
  • Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.

But we won't merge that docs update until PBJS 10.0.

@muuki88
Copy link
Contributor

muuki88 commented May 15, 2025

Hi @pratik-chavan-advertising-dot-com

Can you update the docs according to the review comments from Bret?

@pratik-chavan-advertising-dot-com
Copy link
Contributor Author

Hi @muuki88 @patmmccann I've updated the PR with the requested changes. Please let me know if everything looks good now.

Also, do you have an estimate for the pbjs version 10.0 launch timeline?

@ChrisHuie ChrisHuie merged commit 21eaced into prebid:master Jul 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants