-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rename imds adapter to advertising to reflect ownership change to advertising.com #5943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename imds adapter to advertising to reflect ownership change to advertising.com #5943
Conversation
…rand Update imds adapter to advertising to reflect the ownership change
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…rand Add newline char to synacormedia docs
bretg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename on the Prebid.js side was premature, IMO. The ability for publishers to build your imds adapter into their package using the download page is now broken.
Here's what you need to do to fix:
- Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
- Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.
All we did was merge the change into the unreleased 10 branch; it isnt in master |
Cool. I still recommend doing these things:
But we won't merge that docs update until PBJS 10.0. |
|
Hi @pratik-chavan-advertising-dot-com Can you update the docs according to the review comments from Bret? |
… version notes on both
…rand Imds rebrand
|
Hi @muuki88 @patmmccann I've updated the PR with the requested changes. Please let me know if everything looks good now. Also, do you have an estimate for the pbjs version 10.0 launch timeline? |
🏷 Type of documentation
📋 Checklist
prebid/Prebid.js#12878
prebid/prebid-server#4258