Skip to content

Conversation

@pb-pete
Copy link
Contributor

@pb-pete pb-pete commented Mar 6, 2025

🏷 Type of documentation

  • update bid adapter

📋 Checklist

@netlify
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 0b4a2d7
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67c9b3e5e9ddd4000874fb73
😎 Deploy Preview https://deploy-preview-5926--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg
Copy link
Contributor

bretg commented Mar 6, 2025

And FWIW, it's likely to take at least a month before your Prebid Server bid adapter will be merged. If you want to add the new parameters for PBJS, I would recommend removing the pbs: true flag for now and submitting a separate docs PR that can hang out waiting for the eventual server merge.

@pb-pete
Copy link
Contributor Author

pb-pete commented Mar 6, 2025

And FWIW, it's likely to take at least a month before your Prebid Server bid adapter will be merged. If you want to add the new parameters for PBJS, I would recommend removing the pbs: true flag for now and submitting a separate docs PR that can hang out waiting for the eventual server merge.

Agree. pbs flag removed. Description Updated.

@bretg bretg added LGTM and removed needs work labels Mar 6, 2025
@bretg
Copy link
Contributor

bretg commented Mar 6, 2025

this was released with PBJS 9.33. merging.

@bretg bretg merged commit 9a7d8b1 into prebid:master Mar 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants