Skip to content

Conversation

@tradplus
Copy link
Contributor

@tradplus tradplus commented Jan 9, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit e546d2d
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67921d8487bcf3000823761d
😎 Deploy Preview https://deploy-preview-5794--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg
Copy link
Contributor

bretg commented Jan 9, 2025

Actually, looking at the code here, I think there's a problem. This documentation says zoneId is optional, but the json schema says it's required.

We need to talk about what zoneId actually is because it's part of the endpoint domain (https://{{ZoneID}}adx.tradplusad.com/{{AccountID}}/pserver) It's a strict rule in Prebid Server that publishers cannot be made to supply geographic information. It's ok if 'zoneId' is some kind of inventory identifier, but it's not ok if 'zone' is like 'Europe'. If so, zone needs to be optional and the bid adapter code needs to be updated to have a default.

@tradplus
Copy link
Contributor Author

@bretg Thanks for your question. We have adjusted zoneId to be optional prebid/prebid-server-java#3680. Regarding the value transmission of ZoneID, we confirm that we will not transmit related geographic information; it will only be used as an inventory identifier.

@tradplus
Copy link
Contributor Author

@bretg hi,the json schema has been updated.

@muuki88 muuki88 merged commit 6f61213 into prebid:master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants