Mobile: Rewarded Ad Unit Enhancements #5659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
CC: @teqblaze-yurii |
bretg
suggested changes
Nov 7, 2024
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
@OlenaTeqBlaze - first, thanks for the enhanced feature and docs.
Please fix the linting errors and consider the comments left inline.
bretg
suggested changes
Nov 12, 2024
bretg
approved these changes
Nov 13, 2024
Contributor
|
@OlenaTeqBlaze can you resolve the merge conflicts please 😄 |
Contributor
|
@OlenaTeqBlaze - please resolve conflicts. Thanks. |
Contributor
Author
|
Apologies for the delay, the conflicts have been resolved. |
Contributor
|
Thanks for resolving conflicts the first time. You other changes conflicted with those again. Sorry for the delay on our end. Once resolved, I'll merge this and @teqblaze-yurii may review post merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist
The issue in the mobile repo: prebid/prebid-mobile-ios#1056