New Adapter: Adoppler/ElementaTv #4639
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1)Adoppler adapter now has new name ElementalTv 2)Left support adoppler adapter name 3)Update endpoint url 4)Remove clientId param, as it not used anymore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adapters/elementaltv/elementaltv.go
Outdated
| } | ||
|
|
||
| bidder := &AdopplerAdapter{ | ||
| bidder := &ElementalTvAdapter{ |
There was a problem hiding this comment.
You can call this simply "adapter", the ElementalTvAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be ElementalTvAdapter.ElementalTvAdapter which looks a little redundant. See example below:
package foo
type adapter struct {
endpoint string
}
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
return &adapter{endpoint: "https://www.foo.com"}, nil
}
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
1) Code refactor rename ElementalTvAdapter to adapter 2) Add OpenRtb version 2.6
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
pavel-ptashyts
changed the title
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)Adoppler adapter now has new name ElementalTv
2)Left support adoppler adapter name
3)Update endpoint url
4)Remove clientId param, as it not used anymore