Connatix: support GPID #4482
Closed
Connatix: support GPID #4482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
SyntaxNode
reviewed
Sep 4, 2025
Contributor
SyntaxNode
left a comment
SyntaxNode
left a comment
There was a problem hiding this comment.
Consider adding a supplemental test where the gpid is empty, so the expected behavior is documented via the tests.
adapters/connatix/models.go
Outdated
|
|
||
| type impExtIncoming struct { | ||
| Bidder openrtb_ext.ExtImpConnatix `json:"bidder"` | ||
| Gpid string `json:"gpid"` |
Contributor
There was a problem hiding this comment.
Nitpick: Per Go naming convention, these should be GPID.
adapters/connatix/models.go
Outdated
|
|
||
| type impExt struct { | ||
| Connatix impExtConnatix `json:"connatix"` | ||
| Gpid string `json:"gpid"` |
Contributor
There was a problem hiding this comment.
Do you want to add omitempty to not output the field when the gpid is empty?
Contributor
Author
|
@SyntaxNode thanks, addressed |
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Sep 11, 2025
Contributor
Author
|
redundant due to #4521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the
gpidfrom the incoming bid request, in the outgoing bid request.Equivalent PR for PBS-JAVA