CpmStar: Adapter Update bidder implementation to allow imp.ext passth… #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough with the correct custom parameters.
AntoxaAntoxic
requested changes
Oct 14, 2025
| "USD" | ||
| ], | ||
| "source" : | ||
| {"tid" : "${json-unit.any-string}"}, |
Comment on lines
84
to
91
| final Map<String, Object> extMap = mapper.mapper().convertValue(imp.getExt(), new TypeReference<>() { | ||
| }); | ||
| final Map<String, Object> bidderMap = (Map<String, Object>) extMap.remove("bidder"); | ||
| if (bidderMap != null) { | ||
| extMap.putAll(bidderMap); | ||
| } | ||
| final ObjectNode newExt = mapper.mapper().valueToTree(extMap); | ||
| return imp.toBuilder().ext(newExt).build(); |
Collaborator
There was a problem hiding this comment.
I'd probably use the following approach:
final ObjectNode impExt = imp.getExt().deepCopy();
final JsonNode bidderNode = impExt.remove("bidder");
bidderNode.fields().forEachRemaining(field -> impExt.set(field.getKey(), field.getValue()));
return imp.toBuilder().ext(impExt).build();
Comment on lines
84
to
91
| final Map<String, Object> extMap = mapper.mapper().convertValue(imp.getExt(), new TypeReference<>() { | ||
| }); | ||
| final Map<String, Object> bidderMap = (Map<String, Object>) extMap.remove("bidder"); | ||
| if (bidderMap != null) { | ||
| extMap.putAll(bidderMap); | ||
| } | ||
| final ObjectNode newExt = mapper.mapper().valueToTree(extMap); | ||
| return imp.toBuilder().ext(newExt).build(); |
Collaborator
There was a problem hiding this comment.
Also please cover the changes with the unit test (the existing fields like gpid should be preserved - an additional case)
src/test/resources/org/prebid/server/it/openrtb2/cpmstar/test-auction-cpmstar-request.json
Show resolved
Hide resolved
AntoxaAntoxic
approved these changes
Oct 22, 2025
CTMBNara
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rough with the correct custom parameters.
🔧 Type of changes
✨ What's the context?
#4220