-
Notifications
You must be signed in to change notification settings - Fork 224
Sparteo: add required query params to adapter endpoint #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparteo: add required query params to adapter endpoint #4225
Conversation
cfe7ad9 to
4889865
Compare
c6b30de to
9af1a4a
Compare
9af1a4a to
15ef06e
Compare
|
Hi @osulzhenko . |
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, do you have the same PR for the PBS Go? If yes, please link it in the PR
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
done |
|
Hey @AntoxaAntoxic, |
1dca8a2 to
506fe83
Compare
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldAppendSiteDomainAndNetworkIdAsQueryParams() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant a test methods order - you've placed tests for makeBids in between the tests for makeHttpRequests
🔧 Type of changes
✨ What's the context?
We want to support new required query params when calling our SSP
The Go PR: prebid/prebid-server#4556
🧠 Rationale behind the change
Technical integration changes on our side
🔎 New Bid Adapter Checklist
🧪 Test plan
Tested locally and covered by test
🏎 Quality check