Skip to content

Conversation

@t-sormonte
Copy link
Contributor

@t-sormonte t-sormonte commented Oct 1, 2025

🔧 Type of changes

  • bid adapter update

✨ What's the context?

We want to support new required query params when calling our SSP
The Go PR: prebid/prebid-server#4556

🧠 Rationale behind the change

Technical integration changes on our side

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Tested locally and covered by test

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@t-sormonte t-sormonte force-pushed the Sparteo--add-required-query-params-to-adapter-endpoint branch 4 times, most recently from cfe7ad9 to 4889865 Compare October 8, 2025 13:34
@t-sormonte t-sormonte force-pushed the Sparteo--add-required-query-params-to-adapter-endpoint branch 2 times, most recently from c6b30de to 9af1a4a Compare October 22, 2025 09:07
@t-sormonte t-sormonte force-pushed the Sparteo--add-required-query-params-to-adapter-endpoint branch from 9af1a4a to 15ef06e Compare October 27, 2025 09:32
@t-sormonte t-sormonte marked this pull request as ready for review October 27, 2025 12:59
@t-sormonte
Copy link
Contributor Author

Hi @osulzhenko .
The PR is now ready to review. When you have time could you assign reviewers please ?
Thank you

@osulzhenko osulzhenko requested review from AntoxaAntoxic and CTMBNara and removed request for AntoxaAntoxic October 31, 2025 09:56
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, do you have the same PR for the PBS Go? If yes, please link it in the PR

@t-sormonte
Copy link
Contributor Author

Hi, do you have the same PR for the PBS Go? If yes, please link it in the PR

done

@t-sormonte
Copy link
Contributor Author

Hey @AntoxaAntoxic,
Thank you for the review, i have updated the PR and let my questions opened.
Please let me know if you see additional changes that should be done.

@t-sormonte t-sormonte force-pushed the Sparteo--add-required-query-params-to-adapter-endpoint branch from 1dca8a2 to 506fe83 Compare November 4, 2025 11:14
}

@Test
public void makeHttpRequestsShouldAppendSiteDomainAndNetworkIdAsQueryParams() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a test methods order - you've placed tests for makeBids in between the tests for makeHttpRequests

AntoxaAntoxic
AntoxaAntoxic previously approved these changes Nov 14, 2025
@CTMBNara CTMBNara merged commit 0c6585e into prebid:master Nov 18, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants