-
Notifications
You must be signed in to change notification settings - Fork 224
optable-targeting: Optimize Optable requests for more precise ranging and performance insights #4222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CTMBNara
merged 7 commits into
prebid:master
from
Optable:optable-targeting-improvement
Oct 21, 2025
Merged
optable-targeting: Optimize Optable requests for more precise ranging and performance insights #4222
CTMBNara
merged 7 commits into
prebid:master
from
Optable:optable-targeting-improvement
Oct 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Sep 29, 2025
...src/main/java/org/prebid/server/hooks/modules/optable/targeting/model/OptableAttributes.java
Outdated
Show resolved
Hide resolved
.../main/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/BidRequestEnricher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/BidRequestEnricher.java
Outdated
Show resolved
Hide resolved
...g/prebid/server/hooks/modules/optable/targeting/model/config/OptableTargetingProperties.java
Outdated
Show resolved
Hide resolved
...g/prebid/server/hooks/modules/optable/targeting/model/config/OptableTargetingProperties.java
Outdated
Show resolved
Hide resolved
...g/prebid/server/hooks/modules/optable/targeting/model/config/OptableTargetingProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/BidRequestEnricher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/BidRequestEnricher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/BidRequestEnricher.java
Outdated
Show resolved
Hide resolved
8 tasks
CTMBNara
previously approved these changes
Oct 6, 2025
Comment on lines
150
to
151
| final String inserter = Optional.ofNullable(eid.getInserter()).orElse(""); | ||
| return "%s_%s".formatted(inserter, eid.getSource()); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous approach with ObjectUtil.getIfNotNullOrDefault a bit confused me, please change to this:
return "%s_%s".formatted(StringUtils.defaultString(eid.getInserter()), eid.getSource());
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CTMBNara
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Improve module behavior:
Introduce merge policies for the case when original request already contains an optable-inserted (that is when inserter==optable) EID with the same source as the one obtained from Optable Targeting API. By default the module will skip such EIDs - i.e. will not replace or merge and will just relay the EID from the client as is. However it can be configured per source to either merge or replace or remove such EIDs via
optable-inserter-eids-mergeoroptable-inserter-eids-replaceoroptable-inserter-eids-ignorecorrespondingly.Pass an original User Agent and a client/server flag in the Targeting API request in order for Optable Targeting Server to differentiate the logs by source.
Optable EID Merging Rules:
optable-inserter-eids-mergeconfig param.optable-inserter-eids-replaceconfig param.optable-inserter-eids-ignoreconfig param.optable-inserter-eids-merge,optable-inserter-eids-replaceand `optable-inserter-eids-ignore are take an array of strings, where each item corresponds to a EID source value for which the rule is applicable.🧠 Rationale behind the change
More accurate ranging of incoming traffic
🧪 Test plan
Unit Tests
Manual Integration Tests
🏎 Quality check