Skip to content

Conversation

@EmilNadimanov
Copy link
Contributor

@EmilNadimanov EmilNadimanov commented Sep 22, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

#4141 : porting prebid/prebid-server#4413

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

Updated an existing unit test and the integration-test fixtures

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@EmilNadimanov EmilNadimanov changed the title Port 4141 sovrn fix passing through gpid Sovrn pass-through imp.ext Sep 22, 2025
@EmilNadimanov EmilNadimanov changed the title Sovrn pass-through imp.ext Sovrn: pass-through imp.ext unaltered Sep 22, 2025
@EmilNadimanov
Copy link
Contributor Author

EmilNadimanov commented Sep 22, 2025

For context: the Sovrn adapter in prebid-server-go seems to have been overwriting the imp.ext, effectively removing imp.ext.gpid from the payload. This was not the case in the prebid-server-java implementation where gpid was correctly passed-through.
The accepted solution in the original PR does a bit more than just fixing the problem, so I brought the change over to keep code in sync.

@CTMBNara CTMBNara merged commit 0359db8 into prebid:master Oct 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Sovrn: Fix passing through imp.ext.gpid

3 participants