Skip to content

Conversation

@SamuelAlejandroNT
Copy link

… to proper Imps, fix getBidType for video, update test payloads, make lambda variable final

🔧 Type of changes

  • [ x] new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

A new bid adapter AlvadsBidder has been implemented, and the bid type determination (BidType) logic has been corrected to properly distinguish between banner and video Imps. Test payloads were also updated to reflect separate banner and video Imps.

🧠 Rationale behind the change

Previously, the getBidType method always returned banner, even when the Imp was a video. This caused test failures and incorrect bid type mapping. The changes include:

Mapping each Bid to its corresponding AlvaAdsImp using impId.

Returning BidType.video when the Imp has a video object.

Updating test payloads to include separate banner and video Imps.

Ensuring lambda variables are final to comply with Java requirements.

No significant trade-offs were involved; the change is internal logic and test improvements.

🔎 New Bid Adapter Checklist

  • [x ] verify email contact works
  • [ x] NO fully dynamic hostnames
  • [ x] geographic host parameters are NOT required
  • [ x] direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • [x ] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • [ x] cover an adapter configuration with an integration test

🧪 Test plan

Bids were tested with both banner and video Imps. The results were verified to ensure:

Banner bids return BidType.banner.

Video bids return BidType.video.

Unit test makeBidsShouldReturnBidderBidsWithFullFields passes successfully.

🏎 Quality check

  • [x ] Are your changes following our code style guidelines?
  • [x ] Are there any breaking changes in your code?
  • [x ] Does your test coverage exceed 90%?
  • [x ] Are there any erroneous console logs, debuggers or leftover code in your changes?

… to proper Imps, fix getBidType for video, update test payloads, make lambda variable final
@SamuelAlejandroNT SamuelAlejandroNT deleted the alvads-fix branch September 18, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant