Skip to content

Conversation

@mbonnafon
Copy link
Contributor

@mbonnafon mbonnafon commented Sep 8, 2025

🔧 Type of changes

  • bid adapter update

🧠 Rationale behind the change

Our endpoint should now be pbs.mobkoi.com/bid/prebidserver.

🧪 Test plan

Endpoint is reachable:

(base) > $ curl -X POST -d '{}' https://pbs.mobkoi.com/bid                                                                                                                                                                                                                                                                                                                             
{"error":"Bot traffic not allowed"}%

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@mbonnafon mbonnafon marked this pull request as ready for review September 8, 2025 13:43
@AntoxaAntoxic
Copy link
Collaborator

Hi @mbonnafon

There is another PR #4080 which also adds integrationType, but it has a different mapping. Could you double-check that PR and come up with the single correct version of the changes?

Thanks

@mbonnafon mbonnafon force-pushed the update-mobkoi-pbs-endpoint branch from 6c8d845 to aab2009 Compare September 10, 2025 14:26
@mbonnafon
Copy link
Contributor Author

Hi @AntoxaAntoxic,

Thanks for catching that. I think you can close the other PR.

I've discussed with the team members, and we'll go for the simplest option.

That means:

  • Updating domain to pbs.mobkoi.com
  • Updating the path to /bid/prebidserver (which is already implemented) and detecting the prebidserver source from the path instead of the bid request custom extension field integration type.
curl -X POST -d '{}' https://pbs.mobkoi.com/bid/prebidserver
{"error":"Bot traffic not allowed"}%

This decision is reflected by aab2009

@mbonnafon mbonnafon changed the title Mobkoi: Update endpoint and add integration type Mobkoi: Update endpoint Sep 10, 2025
@mbonnafon
Copy link
Contributor Author

Hi @AntoxaAntoxic, @CTMBNara, do you know what the next steps are for a merge?

@CTMBNara CTMBNara merged commit fbdf7fd into prebid:master Sep 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants