Skip to content

Conversation

@SamuelAlejandroNT
Copy link

🔧 Type of changes

  • [ x] new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

A new bid adapter for AlvaAds (alvads) is being added. This allows Prebid Server to send bid requests to AlvaAds and receive valid bids to display ads on the publisher’s site or app. It handles the AlvaAds-specific Imp.ext, maps the responses (BidResponse), and integrates seamlessly with Prebid Server’s existing infrastructure.

🧠 Rationale behind the change

The main goal of this change is to integrate AlvaAds as a supported bidder in Prebid Server. This enables publishers to increase auction competition and maximize ad revenue.

Considerations:

Compatibility: Fully compatible with the current Prebid Server objects (BidRequest, Imp, BidResponse).

Safety: Unknown fields in Imp.ext are ignored to prevent mapping errors (@JsonIgnoreProperties(ignoreUnknown = true)).

Testing: Unit tests were added to ensure makeBids() correctly returns bids from simulated responses.

Trade-offs: Advanced features like video or native ad support are not implemented yet; the initial focus is on simple banner support for testing and validation of the bidding flow.

🔎 New Bid Adapter Checklist

  • [ x] verify email contact works
  • [x ] NO fully dynamic hostnames
  • [x ] geographic host parameters are NOT required
  • [ x] direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • [x ] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • [x ] cover an adapter configuration with an integration test

🧪 Test plan

The adapter has been verified using unit tests that simulate bid requests and responses. The makeBids() method has been tested to ensure it correctly maps BidResponse objects to BidderBid objects. No real network calls are required, and the behavior is consistent with Prebid Server expectations.

🏎 Quality check

  • [x ] Are your changes following our code style guidelines?
  • [x ] Are there any breaking changes in your code?
  • [x ] Does your test coverage exceed 90%?
  • [ x] Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic
Copy link
Collaborator

Hi @SamuelAlejandroNT

Is there a PR for PBS Go? If yes could you mention it here?

Thanks

@AntoxaAntoxic
Copy link
Collaborator

@SamuelAlejandroNT Is the PR ready for review? I see the failed build and some debug logs in the bidder class so I assume the PR might not be ready for review

@SamuelAlejandroNT
Copy link
Author

Hi @AntoxaAntoxic

We haven’t created a PR for PBS Go, only for PBS Java and PB JS.
I’ve removed the debug log from the bidder class. The failed build doesn’t seem related to Alvads, could you confirm please?

Thanks!

Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an integration test to check the configuration of the bidder. There are a lot of them in the repo, please use them as the examples

@AntoxaAntoxic AntoxaAntoxic changed the title alvads initial release New Alvads Adapter Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants