-
Notifications
You must be signed in to change notification settings - Fork 224
New Alvads Adapter #4166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Alvads Adapter #4166
Conversation
|
Is there a PR for PBS Go? If yes could you mention it here? Thanks |
|
@SamuelAlejandroNT Is the PR ready for review? I see the failed build and some debug logs in the bidder class so I assume the PR might not be ready for review |
|
We haven’t created a PR for PBS Go, only for PBS Java and PB JS. Thanks! |
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an integration test to check the configuration of the bidder. There are a lot of them in the repo, please use them as the examples
src/main/java/org/prebid/server/bidder/alvads/AlvadsBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/alvads/AlvadsBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/alvads/AlvadsBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/alvads/AlvadsImpExt.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/alvads/AlvadsBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/alvads/AlvadsBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/alvads/AlvadsBidderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/AlvaAdsConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/AlvaAdsConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/AlvaAdsConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/alvads/model/AlvadsRequestORTB.java
Show resolved
Hide resolved
9345c6a to
04d9d4a
Compare
🔧 Type of changes
✨ What's the context?
A new bid adapter for AlvaAds (alvads) is being added. This allows Prebid Server to send bid requests to AlvaAds and receive valid bids to display ads on the publisher’s site or app. It handles the AlvaAds-specific Imp.ext, maps the responses (BidResponse), and integrates seamlessly with Prebid Server’s existing infrastructure.
🧠 Rationale behind the change
The main goal of this change is to integrate AlvaAds as a supported bidder in Prebid Server. This enables publishers to increase auction competition and maximize ad revenue.
Considerations:
Compatibility: Fully compatible with the current Prebid Server objects (BidRequest, Imp, BidResponse).
Safety: Unknown fields in Imp.ext are ignored to prevent mapping errors (@JsonIgnoreProperties(ignoreUnknown = true)).
Testing: Unit tests were added to ensure makeBids() correctly returns bids from simulated responses.
Trade-offs: Advanced features like video or native ad support are not implemented yet; the initial focus is on simple banner support for testing and validation of the bidding flow.
🔎 New Bid Adapter Checklist
🧪 Test plan
The adapter has been verified using unit tests that simulate bid requests and responses. The makeBids() method has been tested to ensure it correctly maps BidResponse objects to BidderBid objects. No real network calls are required, and the behavior is consistent with Prebid Server expectations.
🏎 Quality check