New Adapter: TeqBlaze #4161
Merged
New Adapter: TeqBlaze #4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Sep 3, 2025
src/main/java/org/prebid/server/bidder/teqblaze/TeqblazeBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/teqblaze/TeqblazeBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/teqblaze/TeqblazeBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/teqblaze/TeqblazeBidderTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class TeqblazeBidderTest extends VertxTest { | ||
|
|
||
| private static final String ENDPOINT_URL = "https://test.com/test"; |
Collaborator
There was a problem hiding this comment.
I would also added a few tests the checks the following:
- headers
- endpoint url
- a set of impIds
src/test/java/org/prebid/server/bidder/teqblaze/TeqblazeBidderTest.java
Outdated
Show resolved
Hide resolved
| "ext": { | ||
| "teqblaze": { | ||
| "placementId": "testPlacementId", | ||
| "type": "publisher" |
This was
linked to
issues
Sep 8, 2025
AntoxaAntoxic
requested changes
Sep 8, 2025
| maintainer-email: support@rocketlab.ai | ||
| usersync: | ||
| enabled: true | ||
| cookie-family-name: teqblaze |
Comment on lines
94
to
96
| } else { | ||
| throw new PreBidException("found no valid impressions"); | ||
| } |
Collaborator
There was a problem hiding this comment.
This else is not reachable, because one of the placementId or endpointId is required by the bidder schema
| } | ||
|
|
||
| private BidType getBidType(Bid bid) { | ||
|
|
Collaborator
There was a problem hiding this comment.
remove an empty line
| redirect: | ||
| url: https://usync.rocketlab.ai/pbserver?gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&gpp={{gpp}}&gpp_sid={{gpp_sid}}&redirect={{redirect_url}} | ||
| support-cors: false | ||
| uid-macro: '{UID}' |
AntoxaAntoxic
approved these changes
Sep 9, 2025
CTMBNara
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#4152
#4175
#4158