-
Notifications
You must be signed in to change notification settings - Fork 224
DATA-22937: LI analytics adapter #4154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
...ava/org/prebid/server/analytics/reporter/liveintent/model/LiveIntentAnalyticsProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/model/PbsjBid.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/LiveIntentAnalyticsReporter.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/LiveIntentAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/LiveIntentAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/LiveIntentAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/liveintent/LiveIntentAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/AnalyticsConfiguration.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/AnalyticsConfiguration.java
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/AnalyticsConfiguration.java
Show resolved
Hide resolved
...st/java/org/prebid/server/analytics/reporter/liveintent/LiveintentAnalyticsReporterTest.java
Outdated
Show resolved
Hide resolved
|
@CTMBNara, please review this one more time |
|
@SuperIzya could you please update tests? |
We will do it. Thank you. |
|
Hi, @CTMBNara @osulzhenko could you take a look at the updated tests? Thank you! |
|
@peixunzhang pls also fix checkstyle issues: https://github.com/prebid/prebid-server-java/actions/runs/18750513247/job/53733975501?pr=4154 |
I fixed the style here. Please take a look. Thank you! |
|
Hi @osulzhenko, I noticed a failed test in GppTransmitEidsActivitiesSpec, though we didn’t modify that file in this PR. I’m not sure what’s causing the failed test 🤔 Should we try rerunning the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something happened to the indents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it! I noticed that the failed test message in GppTransmitEidsActivitiesSpec.groovy is:
"GPP string invalid: Unable to decode '$invalidGpp'".toString()
The test is this one line 3615:
PBS amp call when privacy module contain invalid GPP string shouldn't remove EIDS fields in request and emit warning in response in line 2020 here
It seems that the failed test we’re seeing is coming from there. I couldn't find the place where the indents have an issue. Could you help me by pointing out where the wrong indent is failing the test so I can fix it? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peixunzhang My comment wasn't about the failed tests :) Please correct all the indentations in the file; they're too big. You'll see the difference if you look at the other test classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... I see. You already fixed it in other commit. Nevermind then (:
|
@peixunzhang functional tests currently have some flaky tests; it's not related to your code or impacting decision about merging it. Hopefully, it will be resolved sooner rather than later |
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check