Skip to content

Conversation

@SuperIzya
Copy link
Contributor

@SuperIzya SuperIzya commented Aug 25, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested a review from CTMBNara September 15, 2025 13:22
@osulzhenko osulzhenko requested a review from CTMBNara September 23, 2025 09:32
@SuperIzya SuperIzya requested a review from CTMBNara September 26, 2025 09:47
@SuperIzya
Copy link
Contributor Author

@CTMBNara, please review this one more time

CTMBNara
CTMBNara previously approved these changes Oct 13, 2025
@osulzhenko
Copy link
Collaborator

@SuperIzya could you please update tests?

@peixunzhang
Copy link

peixunzhang commented Oct 22, 2025

@SuperIzya could you please update tests?

We will do it. Thank you.
cc @SuperIzya

@peixunzhang
Copy link

peixunzhang commented Oct 23, 2025

Hi, @CTMBNara @osulzhenko could you take a look at the updated tests? Thank you!

@osulzhenko
Copy link
Collaborator

@peixunzhang pls also fix checkstyle issues: https://github.com/prebid/prebid-server-java/actions/runs/18750513247/job/53733975501?pr=4154

@peixunzhang
Copy link

@peixunzhang pls also fix checkstyle issues: https://github.com/prebid/prebid-server-java/actions/runs/18750513247/job/53733975501?pr=4154

I fixed the style here. Please take a look. Thank you!

@peixunzhang
Copy link

peixunzhang commented Oct 28, 2025

Hi @osulzhenko, I noticed a failed test in GppTransmitEidsActivitiesSpec, though we didn’t modify that file in this PR. I’m not sure what’s causing the failed test 🤔 Should we try rerunning the tests?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something happened to the indents.

Copy link

@peixunzhang peixunzhang Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it! I noticed that the failed test message in GppTransmitEidsActivitiesSpec.groovy is:
"GPP string invalid: Unable to decode '$invalidGpp'".toString()
The test is this one line 3615:
PBS amp call when privacy module contain invalid GPP string shouldn't remove EIDS fields in request and emit warning in response in line 2020 here
It seems that the failed test we’re seeing is coming from there. I couldn't find the place where the indents have an issue. Could you help me by pointing out where the wrong indent is failing the test so I can fix it? Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peixunzhang My comment wasn't about the failed tests :) Please correct all the indentations in the file; they're too big. You'll see the difference if you look at the other test classes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I see. You already fixed it in other commit. Nevermind then (:

@osulzhenko
Copy link
Collaborator

@peixunzhang functional tests currently have some flaky tests; it's not related to your code or impacting decision about merging it. Hopefully, it will be resolved sooner rather than later

@CTMBNara CTMBNara merged commit 85c22d0 into prebid:master Oct 28, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants