Skip to content

Conversation

@muuki88
Copy link
Contributor

@muuki88 muuki88 commented Aug 20, 2025

A new metric was added, but the prometheus labels were missing

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

A new metric was added ( activity ) without adding a prometheus match rule

🧠 Rationale behind the change

Prometheus labels work as expected

🧪 Test plan

We run it in production already

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code? - there are, but it's broken before, so meh.
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

A new metric was added, but the prometheus labels were missing
@Net-burst Net-burst self-assigned this Sep 3, 2025
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CTMBNara CTMBNara merged commit 27f5ece into master Sep 3, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the muuki88-patch-1 branch September 3, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants