Skip to content

optable-targeting: Fix query string construction when IDs are missing. #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
Aug 21, 2025
Merged

optable-targeting: Fix query string construction when IDs are missing. #4138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...argeting/src/main/java/org/prebid/server/hooks/modules/optable/targeting/model/Query.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.prebid.server.hooks.modules.optable.targeting.model;

import lombok.Value;
import org.apache.commons.lang3.StringUtils;

@Value(staticConstructor = "of")
public class Query {
Expand All @@ -11,10 +10,6 @@ public class Query {
String attributes;

public String toQueryString() {
if (StringUtils.isEmpty(ids) && !StringUtils.isEmpty(attributes)) {
return attributes.substring(1);
}

return ids + attributes;
}
}
4 changes: 3 additions & 1 deletion ...test/java/org/prebid/server/hooks/modules/optable/targeting/v1/core/QueryBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public void shouldBuildFullQueryString() {
// then
assertThat(query.getIds()).isEqualTo("&id=e%3Aemail&id=p%3A123");
assertThat(query.getAttributes()).isEqualTo("&gdpr_consent=tcf&gdpr=1&timeout=100ms");
assertThat(query.toQueryString())
.isEqualTo("&id=e%3Aemail&id=p%3A123&gdpr_consent=tcf&gdpr=1&timeout=100ms");
}

@Test
Expand Down Expand Up @@ -94,7 +96,7 @@ public void shouldBuildQueryStringWhenIdsListIsEmptyAndIpIsPresent() {

// then
assertThat(query).isNotNull();
assertThat(query.toQueryString()).isEqualTo("gdpr=0");
assertThat(query.toQueryString()).isEqualTo("&gdpr=0");
}

@Test
Expand Down
Loading