Skip to content

TheTradeDesk adapter should resolve burl if not resolved #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
Aug 20, 2025
Merged

TheTradeDesk adapter should resolve burl if not resolved #4133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ private static Bid resolvePriceMacros(Bid bid) {
return bid.toBuilder()
.nurl(StringUtils.replace(bid.getNurl(), PRICE_MACRO, priceAsString))
.adm(StringUtils.replace(bid.getAdm(), PRICE_MACRO, priceAsString))
.burl(StringUtils.replace(bid.getBurl(), PRICE_MACRO, priceAsString))
.build();
}
}
101 changes: 74 additions & 27 deletions src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,8 @@ public void makeBidsShouldReplacePriceMacroInNurlAndAdmWithBidPrice() throws Jso
.impid("123")
.price(BigDecimal.valueOf(1.23))
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -521,8 +522,9 @@ public void makeBidsShouldReplacePriceMacroInNurlAndAdmWithBidPrice() throws Jso
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm, Bid::getPrice)
.containsOnly(tuple("http://example.com/nurl?price=1.23", "<div>Price: 1.23</div>", BigDecimal.valueOf(1.23)));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl, Bid::getPrice)
.containsOnly(tuple("http://example.com/nurl?price=1.23", "<div>Price: 1.23</div>",
"https://adsrvr.org/feedback/xxx?wp=1.23&param2=xyz", BigDecimal.valueOf(1.23)));
}

@Test
Expand All @@ -534,7 +536,8 @@ public void makeBidsShouldReplacePriceMacroWithZeroWhenBidPriceIsNull() throws J
.impid("123")
.price(null)
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -543,8 +546,9 @@ public void makeBidsShouldReplacePriceMacroWithZeroWhenBidPriceIsNull() throws J
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl?price=0", "<div>Price: 0</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple("http://example.com/nurl?price=0", "<div>Price: 0</div>",
"https://adsrvr.org/feedback/xxx?wp=0&param2=xyz"));
}

@Test
Expand All @@ -556,7 +560,8 @@ public void makeBidsShouldReplacePriceMacroWithZeroWhenBidPriceIsZero() throws J
.impid("123")
.price(BigDecimal.ZERO)
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -565,8 +570,9 @@ public void makeBidsShouldReplacePriceMacroWithZeroWhenBidPriceIsZero() throws J
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl?price=0", "<div>Price: 0</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple("http://example.com/nurl?price=0", "<div>Price: 0</div>",
"https://adsrvr.org/feedback/xxx?wp=0&param2=xyz"));
}

@Test
Expand All @@ -578,7 +584,8 @@ public void makeBidsShouldReplacePriceMacroInNurlOnlyWhenAdmDoesNotContainMacro(
.impid("123")
.price(BigDecimal.valueOf(5.67))
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
.adm("<div>No macro here</div>")));
.adm("<div>No macro here</div>")
.burl("http://example.com/burl")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -587,8 +594,9 @@ public void makeBidsShouldReplacePriceMacroInNurlOnlyWhenAdmDoesNotContainMacro(
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl?price=5.67", "<div>No macro here</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple("http://example.com/nurl?price=5.67", "<div>No macro here</div>",
"http://example.com/burl"));
}

@Test
Expand All @@ -600,7 +608,8 @@ public void makeBidsShouldReplacePriceMacroInAdmOnlyWhenNurlDoesNotContainMacro(
.impid("123")
.price(BigDecimal.valueOf(8.90))
.nurl("http://example.com/nurl")
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}</div>")
.burl("http://example.com/burl")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -609,8 +618,9 @@ public void makeBidsShouldReplacePriceMacroInAdmOnlyWhenNurlDoesNotContainMacro(
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl", "<div>Price: 8.9</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple("http://example.com/nurl", "<div>Price: 8.9</div>",
"http://example.com/burl"));
}

@Test
Expand All @@ -622,7 +632,8 @@ public void makeBidsShouldNotReplacePriceMacroWhenNurlAndAdmDoNotContainMacro()
.impid("123")
.price(BigDecimal.valueOf(12.34))
.nurl("http://example.com/nurl")
.adm("<div>No macro</div>")));
.adm("<div>No macro</div>")
.burl("http://example.com/burl")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -631,8 +642,9 @@ public void makeBidsShouldNotReplacePriceMacroWhenNurlAndAdmDoNotContainMacro()
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl", "<div>No macro</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple("http://example.com/nurl", "<div>No macro</div>",
"http://example.com/burl"));
}

@Test
Expand All @@ -644,7 +656,8 @@ public void makeBidsShouldHandleNullNurlAndAdm() throws JsonProcessingException
.impid("123")
.price(BigDecimal.valueOf(15.00))
.nurl(null)
.adm(null)));
.adm(null)
.burl(null)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -653,8 +666,8 @@ public void makeBidsShouldHandleNullNurlAndAdm() throws JsonProcessingException
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple(null, null));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple(null, null, null));
}

@Test
Expand All @@ -666,7 +679,8 @@ public void makeBidsShouldReplaceMultiplePriceMacrosInSameField() throws JsonPro
.impid("123")
.price(BigDecimal.valueOf(9.99))
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}&backup_price=${AUCTION_PRICE}")
.adm("<div>Price: ${AUCTION_PRICE}, Fallback: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}, Fallback: ${AUCTION_PRICE}</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&backup_wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -675,8 +689,11 @@ public void makeBidsShouldReplaceMultiplePriceMacrosInSameField() throws JsonPro
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl?price=9.99&backup_price=9.99", "<div>Price: 9.99, Fallback: 9.99</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple(
"http://example.com/nurl?price=9.99&backup_price=9.99",
"<div>Price: 9.99, Fallback: 9.99</div>",
"https://adsrvr.org/feedback/xxx?wp=9.99&backup_wp=9.99&param2=xyz"));
}

@Test
Expand All @@ -688,7 +705,8 @@ public void makeBidsShouldHandleLargeDecimalPrices() throws JsonProcessingExcept
.impid("123")
.price(new BigDecimal("123456789.123456789"))
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
.adm("<div>Price: ${AUCTION_PRICE}</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
Expand All @@ -697,8 +715,37 @@ public void makeBidsShouldHandleLargeDecimalPrices() throws JsonProcessingExcept
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm)
.containsOnly(tuple("http://example.com/nurl?price=123456789.123456789", "<div>Price: 123456789.123456789</div>"));
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple(
"http://example.com/nurl?price=123456789.123456789",
"<div>Price: 123456789.123456789</div>",
"https://adsrvr.org/feedback/xxx?wp=123456789.123456789&param2=xyz"));
}

@Test
public void makeBidsShouldReplacePriceMacroInBurlIfNurlAndAdmDoNotContainMacro() throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
givenBidResponse(bidBuilder -> bidBuilder
.mtype(1)
.impid("123")
.price(BigDecimal.valueOf(7.77))
.nurl("http://example.com/nurl")
.adm("<div>No macro</div>")
.burl("https://adsrvr.org/feedback/xxx?wp=${AUCTION_PRICE}&param2=xyz")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(BidderBid::getBid)
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl)
.containsOnly(tuple(
"http://example.com/nurl",
"<div>No macro</div>",
"https://adsrvr.org/feedback/xxx?wp=7.77&param2=xyz"));
}

private String givenBidResponse(UnaryOperator<Bid.BidBuilder> bidCustomizer) throws JsonProcessingException {
Expand Down
Loading