-
Notifications
You must be signed in to change notification settings - Fork 224
Test: Rule Engine #4103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Test: Rule Engine #4103
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
02ab85c
Changed result function config field from config to args, fixed filte…
And1sS c3a3fff
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an 957262f
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an f15d769
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an 8ec56a1
Initial commit of rule engine functional test
marki1an 63767ef
Initial commit of rule engine functional test
marki1an ab17da1
Initial commit of rule engine functional test
marki1an 015a7a4
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an f8ff419
Merge remote-tracking branch 'origin/ruleengine' into test/ruleengine
marki1an 12a450e
Major update of rule engine functional tests
marki1an bb4acff
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an c2d39ae
Merge branch 'ruleengine' into test/ruleengine
marki1an 6aae51a
Merge remote-tracking branch 'origin/ruleengine' into ruleengine
marki1an b69aea7
Merge branch 'ruleengine' into test/ruleengine
marki1an 5c0254d
Merge remote-tracking branch 'origin/ruleengine' into test/ruleengine
marki1an 4b72217
Clean up code
marki1an 71348bc
Update after minor update
marki1an 59762ee
Merge remote-tracking branch 'origin/ruleengine' into test/ruleengine
marki1an d35ce57
Minor update
marki1an 1062924
Merge remote-tracking branch 'refs/remotes/origin/ruleengine' into te…
marki1an eb01920
Update after review
marki1an 2a771df
Roll back launch container to false
marki1an 30b03da
Clean up redundant imports
marki1an 46634fc
Minor update
marki1an 091792a
Update after review
marki1an 4ee6904
Merge remote-tracking branch 'origin/ruleengine' into test/ruleengine
marki1an 3d5be3b
Minor update
marki1an 536ca57
Merge remote-tracking branch 'origin/ruleengine' into test/ruleengine
marki1an e3f35b1
Update after minor change logic
marki1an 569fb3b
GppSectionId remove TCF_EU_V2 from random array
marki1an 6dc82e4
Major update after review
marki1an 67252a9
some minor updates
osulzhenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/test/groovy/org/prebid/server/functional/model/config/PbRulesEngine.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import java.time.ZonedDateTime | ||
|
|
||
| class PbRulesEngine { | ||
|
|
||
| Boolean enabled | ||
| Boolean generateRulesFromBidderConfig | ||
| ZonedDateTime timestamp | ||
| List<RuleSet> ruleSets | ||
|
|
||
| static PbRulesEngine createRulesEngineWithRule(Boolean enabled = true) { | ||
| new PbRulesEngine().tap { | ||
| it.enabled = enabled | ||
| it.generateRulesFromBidderConfig = false | ||
| it.ruleSets = [RuleSet.createRuleSets()] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/test/groovy/org/prebid/server/functional/model/config/ResultFunction.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonValue | ||
|
|
||
| enum ResultFunction { | ||
|
|
||
| INCLUDE_BIDDERS("includeBidders"), | ||
| EXCLUDE_BIDDER("excludeBidders"), | ||
| LOG_A_TAG("logAtag") | ||
|
|
||
| String value | ||
|
|
||
| ResultFunction(String value) { | ||
| this.value = value | ||
| } | ||
|
|
||
| @Override | ||
| @JsonValue | ||
| String toString() { | ||
| return value | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineArguments.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import org.prebid.server.functional.model.bidder.BidderName | ||
|
|
||
| class RuleEngineArguments { | ||
|
|
||
| List<BidderName> bidders | ||
| Integer seatNonBid | ||
| Boolean ifSyncedId | ||
| String analyticsValue | ||
| } |
44 changes: 44 additions & 0 deletions
44
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineFunction.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonValue | ||
|
|
||
| enum RuleEngineFunction { | ||
|
|
||
| DEVICE_COUNTRY("deviceCountry", null), | ||
| DEVICE_COUNTRY_IN("deviceCountryIn", "countries"), | ||
| DATA_CENTER("dataCenter", null), | ||
| DATA_CENTER_IN("dataCenterIn", "datacenters"), | ||
| CHANNEL("channel", null), | ||
| EID_AVAILABLE("eidAvailable", null), | ||
| EID_IN("eidIn", "sources"), | ||
| USER_FPD_AVAILABLE("userFpdAvailable", null), | ||
| FPD_AVAILABLE("fpdAvailable", null), | ||
| GPP_SID_AVAILABLE("gppSidAvailable", null), | ||
| GPP_SID_IN("gppSidIn", "sids"), | ||
| TCF_IN_SCOPE("tcfInScope", null), | ||
| PERCENT("percent", "pct"), | ||
| PREBID_KEY("prebidKey", "key"), | ||
| DOMAIN("domain", null), | ||
| DOMAIN_IN("domainIn", "domains"), | ||
| BUNDLE("bundle", null), | ||
| BUNDLE_IN("bundleIn", "bundles"), | ||
| MEDIA_TYPE_IN("mediaTypeIn", "types"), | ||
| AD_UNIT_CODE("adUnitCode", null), | ||
| AD_UNIT_CODE_IN("adUnitCodeIn", "codes"), | ||
| DEVICE_TYPE("deviceType", null), | ||
| DEVICE_TYPE_IN("deviceTypeIn", "types") | ||
|
|
||
| private String value | ||
| private String fieldName | ||
|
|
||
| RuleEngineFunction(String value, String fieldName) { | ||
| this.value = value | ||
| this.fieldName = fieldName | ||
| } | ||
|
|
||
| @JsonValue | ||
| @Override | ||
| String toString() { | ||
| return value | ||
| } | ||
| } |
37 changes: 37 additions & 0 deletions
37
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineFunctionArgs.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty | ||
| import org.prebid.server.functional.util.PBSUtils | ||
|
|
||
| class RuleEngineFunctionArgs { | ||
|
|
||
| List<Object> countries | ||
| List<Object> datacenters | ||
| List<Object> sources | ||
| List<Object> sids | ||
| @JsonProperty("pct") | ||
| Object percent | ||
| Object key | ||
| List<Object> domains | ||
| List<Object> bundles | ||
| List<Object> codes | ||
| List<Object> types | ||
| String operator | ||
| BigDecimal value | ||
| Currency currency | ||
|
|
||
| static RuleEngineFunctionArgs getDefaultFunctionArgs() { | ||
| new RuleEngineFunctionArgs().tap { | ||
| countries = [PBSUtils.randomString] | ||
| datacenters = [PBSUtils.randomString] | ||
| sources = [PBSUtils.randomString] | ||
| sids = [PBSUtils.randomNumber] | ||
| percent = PBSUtils.getRandomNumber(1, 100) | ||
| key = PBSUtils.randomString | ||
| domains = [PBSUtils.randomString] | ||
| bundles = [PBSUtils.randomString] | ||
| codes = [PBSUtils.randomString] | ||
| types = [PBSUtils.randomString] | ||
| } | ||
| } | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineModelDefault.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| class RuleEngineModelDefault { | ||
|
|
||
| ResultFunction function | ||
| RuleEngineModelDefaultArgs args | ||
| } |
6 changes: 6 additions & 0 deletions
6
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineModelDefaultArgs.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| class RuleEngineModelDefaultArgs { | ||
|
|
||
| String analyticsValue | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineModelRule.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import static java.lang.Boolean.TRUE | ||
| import static org.prebid.server.functional.model.config.RuleEngineModelRuleResult.createRuleEngineModelRuleWithExcludeResult | ||
|
|
||
| class RuleEngineModelRule { | ||
|
|
||
| List<String> conditions | ||
| List<RuleEngineModelRuleResult> results | ||
|
|
||
| static RuleEngineModelRule createRuleEngineModelRule() { | ||
| new RuleEngineModelRule().tap { | ||
| it.conditions = [TRUE as String] | ||
| it.results = [createRuleEngineModelRuleWithExcludeResult()] | ||
| } | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineModelRuleResult.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import org.prebid.server.functional.model.bidder.BidderName | ||
|
|
||
| import static org.prebid.server.functional.model.bidder.BidderName.ACEEX | ||
| import static org.prebid.server.functional.model.bidder.BidderName.OPENX | ||
| import static org.prebid.server.functional.model.config.ResultFunction.EXCLUDE_BIDDER | ||
| import static org.prebid.server.functional.model.config.ResultFunction.INCLUDE_BIDDERS | ||
| import static org.prebid.server.functional.model.config.ResultFunction.LOG_A_TAG | ||
|
|
||
| class RuleEngineModelRuleResult { | ||
|
|
||
| ResultFunction function | ||
| RuleEngineModelRuleResultsArgs args | ||
|
|
||
| static RuleEngineModelRuleResult createRuleEngineModelRuleWithIncludeResult(BidderName bidderName = ACEEX, | ||
| Boolean ifSyncedId = false) { | ||
| new RuleEngineModelRuleResult().tap { | ||
| it.function = INCLUDE_BIDDERS | ||
| it.args = RuleEngineModelRuleResultsArgs.createRuleEngineModelRuleResultsArgs(bidderName, ifSyncedId) | ||
| } | ||
| } | ||
|
|
||
| static RuleEngineModelRuleResult createRuleEngineModelRuleWithExcludeResult(BidderName bidderName = OPENX, | ||
| Boolean ifSyncedId = false) { | ||
| new RuleEngineModelRuleResult().tap { | ||
| it.function = EXCLUDE_BIDDER | ||
| it.args = RuleEngineModelRuleResultsArgs.createRuleEngineModelRuleResultsArgs(bidderName, ifSyncedId) | ||
| } | ||
| } | ||
|
|
||
| static RuleEngineModelRuleResult createRuleEngineModelRuleWithLogATagResult() { | ||
| new RuleEngineModelRuleResult().tap { | ||
| it.function = LOG_A_TAG | ||
| it.args = RuleEngineModelRuleResultsArgs.createRuleEngineModelRuleResultsArgsOnlyATag() | ||
| } | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...st/groovy/org/prebid/server/functional/model/config/RuleEngineModelRuleResultsArgs.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty | ||
| import org.prebid.server.functional.model.bidder.BidderName | ||
| import org.prebid.server.functional.model.response.auction.BidRejectionReason | ||
| import org.prebid.server.functional.util.PBSUtils | ||
|
|
||
| class RuleEngineModelRuleResultsArgs { | ||
|
|
||
| List<BidderName> bidders | ||
| @JsonProperty("seatnonbid") | ||
| BidRejectionReason seatNonBid | ||
| @JsonProperty("analyticsValue") | ||
| String analyticsValue | ||
| @JsonProperty("ifSyncedId") | ||
| Boolean ifSyncedId | ||
|
|
||
| static RuleEngineModelRuleResultsArgs createRuleEngineModelRuleResultsArgs(BidderName bidderName, Boolean ifSyncedId) { | ||
| new RuleEngineModelRuleResultsArgs().tap { | ||
| it.bidders = [bidderName] | ||
| it.analyticsValue = PBSUtils.randomString | ||
| it.ifSyncedId = ifSyncedId | ||
| } | ||
| } | ||
|
|
||
| static RuleEngineModelRuleResultsArgs createRuleEngineModelRuleResultsArgsOnlyATag() { | ||
| new RuleEngineModelRuleResultsArgs().tap { | ||
| it.analyticsValue = PBSUtils.randomString | ||
| } | ||
| } | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/test/groovy/org/prebid/server/functional/model/config/RuleEngineModelSchema.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import groovy.transform.ToString | ||
|
|
||
| import static org.prebid.server.functional.model.config.RuleEngineFunction.DEVICE_COUNTRY_IN | ||
| import static org.prebid.server.functional.model.pricefloors.Country.USA | ||
|
|
||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| class RuleEngineModelSchema { | ||
|
|
||
| RuleEngineFunction function | ||
| RuleEngineFunctionArgs args | ||
osulzhenko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| static RuleEngineModelSchema createDeviceCountryInSchema(List<Object> argsCountries = [USA]) { | ||
| new RuleEngineModelSchema().tap { | ||
| it.function = DEVICE_COUNTRY_IN | ||
| it.args = new RuleEngineFunctionArgs(countries: argsCountries) | ||
| } | ||
| } | ||
| } | ||
23 changes: 23 additions & 0 deletions
23
src/test/groovy/org/prebid/server/functional/model/config/RuleSet.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import static org.prebid.server.functional.model.config.Stage.PROCESSED_AUCTION_REQUEST | ||
| import static org.prebid.server.functional.util.PBSUtils.randomString | ||
|
|
||
| class RuleSet { | ||
|
|
||
| Boolean enabled | ||
| Stage stage | ||
| String name | ||
| String version | ||
| List<RulesEngineModelGroup> modelGroups | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. timestamp? |
||
|
|
||
| static RuleSet createRuleSets() { | ||
| new RuleSet().tap { | ||
| it.enabled = true | ||
| it.stage = PROCESSED_AUCTION_REQUEST | ||
| it.name = randomString | ||
| it.version = randomString | ||
| it.modelGroups = [RulesEngineModelGroup.createRulesModuleGroup()] | ||
| } | ||
| } | ||
| } | ||
29 changes: 29 additions & 0 deletions
29
src/test/groovy/org/prebid/server/functional/model/config/RulesEngineModelGroup.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package org.prebid.server.functional.model.config | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty | ||
| import org.prebid.server.functional.util.PBSUtils | ||
|
|
||
| import static org.prebid.server.functional.model.config.RuleEngineModelRule.createRuleEngineModelRule | ||
| import static org.prebid.server.functional.model.config.RuleEngineModelSchema.createDeviceCountryInSchema | ||
|
|
||
| class RulesEngineModelGroup { | ||
|
|
||
| Integer weight | ||
| String version | ||
| String analyticsKey | ||
| List<RuleEngineModelSchema> schema | ||
| @JsonProperty("default") | ||
| List<RuleEngineModelDefault> modelDefault | ||
| List<RuleEngineModelRule> rules | ||
|
|
||
| static RulesEngineModelGroup createRulesModuleGroup() { | ||
| new RulesEngineModelGroup().tap { | ||
| it.weight = PBSUtils.getRandomNumber(1, 100) | ||
| it.version = PBSUtils.randomString | ||
| it.analyticsKey = PBSUtils.randomString | ||
| it.schema = [createDeviceCountryInSchema()] | ||
| it.modelDefault = [] | ||
| it.rules = [createRuleEngineModelRule()] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/test/groovy/org/prebid/server/functional/model/request/auction/DeviceType.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package org.prebid.server.functional.model.request.auction | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonValue | ||
|
|
||
| enum DeviceType { | ||
|
|
||
| MOBILE_TABLET_GENERAL(1), | ||
| PERSONAL_COMPUTER(2), | ||
| CONNECTED_TV(3), | ||
| PHONE(4), | ||
| TABLET(5), | ||
| CONNECTED_DEVICE(6), | ||
| SET_TOP_BOX(7), | ||
| OOH_DEVICE(8) | ||
|
|
||
| @JsonValue | ||
| final Integer value | ||
|
|
||
| DeviceType(Integer value) { | ||
| this.value = value | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
src/test/groovy/org/prebid/server/functional/model/request/auction/ImpUnitCode.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package org.prebid.server.functional.model.request.auction | ||
|
|
||
| enum ImpUnitCode { | ||
|
|
||
| TAG_ID, | ||
| GPID, | ||
| PB_AD_SLOT, | ||
| STORED_REQUEST | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.