Skip to content

Tappx Adapter: Add GPID support #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 2 commits into from
Aug 1, 2025
+9 −7
Merged

Tappx Adapter: Add GPID support #4089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c532735
Tappx Adapter: Add GPID support
AntoxaAntoxic Jul 28, 2025
c586bfe
Tappx Adapter: Add GPID support
AntoxaAntoxic Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/tappx/TappxBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

public class TappxBidder implements Bidder<BidRequest> {

private static final String VERSION = "1.4";
private static final String VERSION = "1.6";
private static final String TYPE_CNN = "prebid";

private static final TypeReference<ExtPrebid<?, ExtImpTappx>> TAPX_EXT_TYPE_REFERENCE =
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/prebid/server/bidder/tappx/TappxBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public void makeHttpRequestsShouldMakeRequestWithUrl() {

// then
assertThat(result.getErrors()).isEmpty();
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.4&type_cnn=prebid";
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.6&type_cnn=prebid";
assertThat(result.getValue()).hasSize(1)
.allSatisfy(httpRequest -> {
assertThat(httpRequest.getUri()).isEqualTo(expectedUri);
Expand All @@ -165,7 +165,7 @@ public void makeHttpRequestShouldBuildCorrectUriWithPathInHostParameterButWithou

// then
assertThat(result.getErrors()).isEmpty();
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.4&type_cnn=prebid";
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.6&type_cnn=prebid";
assertThat(result.getValue()).hasSize(1)
.allSatisfy(httpRequest -> {
assertThat(httpRequest.getUri()).isEqualTo(expectedUri);
Expand All @@ -190,7 +190,7 @@ public void makeHttpRequestShouldBuildCorrectUriWithEndPointParameterIfMatched()
// then
assertThat(result.getErrors()).isEmpty();
final String expectedUri =
"https://zz855226test.pub.domain/rtb/?tappxkey=tappxkey&v=1.4&type_cnn=prebid";
"https://zz855226test.pub.domain/rtb/?tappxkey=tappxkey&v=1.6&type_cnn=prebid";
assertThat(result.getValue()).hasSize(1)
.allSatisfy(httpRequest -> {
assertThat(httpRequest.getUri()).isEqualTo(expectedUri);
Expand All @@ -214,7 +214,7 @@ public void makeHttpRequestsShouldModifyUrl() {

// then
assertThat(result.getErrors()).isEmpty();
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.4&type_cnn=prebid";
final String expectedUri = "https://ssp.api.domain/rtb/v2/endpoint?tappxkey=tappxkey&v=1.6&type_cnn=prebid";
assertThat(result.getValue()).hasSize(1)
.allSatisfy(httpRequest -> {
assertThat(httpRequest.getUri()).isEqualTo(expectedUri);
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/org/prebid/server/it/openrtb2/tappx/test-auction-tappx-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"tappxkey": "pub-12345-android-9876",
"endpoint": "test",
"bidfloor": 1.5
}
},
"gpid": "/19968336/header-bid-tag-0"
}
}
],
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/org/prebid/server/it/openrtb2/tappx/test-tappx-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"tappxkey": "pub-12345-android-9876",
"endpoint": "test",
"bidfloor": 1.5
}
},
"gpid": "/19968336/header-bid-tag-0"
}
}
],
Expand Down
Loading