Stroeercore Adapter: Add adomain to bids #4076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Jul 24, 2025
Comment on lines
89
to
95
| private static Pair<BidType, Integer> getBidType(String mtype) { | ||
| return switch (mtype) { | ||
| case "banner" -> Pair.of(BidType.banner, 1); | ||
| case "video" -> Pair.of(BidType.video, 2); | ||
| default -> null; | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
Place methods in call order. Also, instead of returning Pair, return BidType and use ordinal() + 1
Collaborator
Author
There was a problem hiding this comment.
not sure it's a good idea overall to be dependent on the order inside the enum
CTMBNara
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check